Rename agent chart (#4019)

Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>

.github/workflows/helm-charts.yaml

@@ -1,6 +1,7 @@
 name: Package & Push Flyte Helm Charts
 
 on:
+  pull_request:
   push:
     branches:
       - master
@@ -13,7 +14,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        chart: ["flyte-binary", "flyte-core", "flyte-agent"]
+        chart: ["flyte-binary", "flyte-core", "flyteagent"]
     steps:
       - name: Checkout
         uses: actions/checkout@v3
@@ -25,12 +26,21 @@ jobs:
           registry: ghcr.io
           username: "${{ secrets.FLYTE_BOT_USERNAME }}"
           password: "${{ secrets.FLYTE_BOT_PAT }}"
-      - name: Publish Helm chart to GHCR
+      - name: Build helm chart
         working-directory: charts
         run: |
           helm dep update ${{ matrix.chart }}
           helm package \
             --app-version=${{ github.sha }} \
             --version=0.0-${{ github.sha }} \
             ${{ matrix.chart }}
+          
+          if ! ls ${{ matrix.chart }}-* 2>&1 >/dev/null;
+          then
+              echo "Chart package not found."
+              exit 1
+          fi
+      - name: Publish Helm chart to GHCR
+        if: ${{ github.event_name == 'push' || github.event_name == 'workflow_dispatch' }}
+        run:
           helm push ${{ matrix.chart }}-*.tgz oci://ghcr.io/flyteorg/helm-charts

.gitignore

@@ -20,7 +20,7 @@ __pycache__/
 /charts/flyte-deps/charts
 /charts/flyte/Chart.lock
 /charts/flyte-binary/Chart.lock
-/charts/flyte-agent/Chart.lock
+/charts/flyteagent/Chart.lock
 /charts/flyte-deps/Chart.lock
 /charts/flyte-core/Chart.lock
 /docker/sandbox-lite/storage/charts

charts/flyte-binary/Chart.yaml

@@ -19,4 +19,4 @@ dependencies:
     condition: flyteagent.enabled
     alias: flyteagent
     version: v0.1.10 # VERSION
-    repository: file://../flyte-agent # REPOSITORY
+    repository: file://../flyteagent # REPOSITORY

charts/flyte-binary/README.md

@@ -8,7 +8,7 @@ Chart for basic single Flyte executable deployment
 
 | Repository | Name | Version |
 |------------|------|---------|
-| file://../flyte-agent | flyteagent(flyteagent) | v0.1.10 |
+| file://../flyteagent | flyteagent(flyteagent) | v0.1.10 |
 
 ## Values
 

charts/flyte-core/Chart.yaml

@@ -8,4 +8,4 @@ dependencies:
     condition: flyteagent.enabled
     alias: flyteagent
     version: v0.1.10 # VERSION
-    repository: file://../flyte-agent # REPOSITORY
+    repository: file://../flyteagent # REPOSITORY

charts/flyte-core/README.md

@@ -8,7 +8,7 @@ A Helm chart for Flyte core
 
 | Repository | Name | Version |
 |------------|------|---------|
-| file://../flyte-agent | flyteagent(flyteagent) | v0.1.10 |
+| file://../flyteagent | flyteagent(flyteagent) | v0.1.10 |
 
 ### Flyte INSTALLATION:
 - [Install helm 3](https://helm.sh/docs/intro/install/)

charts/flyte-agent/values.yaml → charts/flyteagent/values.yaml

@@ -2,9 +2,9 @@
 # FLYTE_AGENT SETTINGS
 # ---------------------------------------------------------------------
 
-# nameOverride String to override flyte-agent.name template
+# nameOverride String to override flyteagent.name template
 nameOverride: ""
-# fullnameOverride String to override flyte-agent.fullname template
+# fullnameOverride String to override flyteagent.fullname template
 fullnameOverride: ""
 # commonLabels Add labels to all the deployed resources
 commonLabels: {}

flyteplugins/go/tasks/plugins/webapi/agent/config.go

@@ -40,7 +40,7 @@ var (
 			},
 		},
 		DefaultAgent: Agent{
-			Endpoint:       "dns:///flyte-agent.flyte.svc.cluster.local:80",
+			Endpoint:       "dns:///flyteagent.flyte.svc.cluster.local:80",
 			Insecure:       true,
 			DefaultTimeout: config.Duration{Duration: 10 * time.Second},
 		},

script/generate_helm.sh

@@ -37,7 +37,7 @@ helm template flyte -n flyte ${DIR}/../charts/flyte-deps/ ${HELM_CAPABILITIES} -
 helm template flyte -n flyte ${DIR}/../charts/flyte-binary/ ${HELM_CAPABILITIES} --debug > ${DIR}/../deployment/sandbox-binary/flyte_sandbox_binary_helm_generated.yaml
 
 # Generate manifest flyte agent
-helm template flyte -n flyte ${DIR}/../charts/flyte-agent/ ${HELM_CAPABILITIES} --debug > ${DIR}/../deployment/agent/flyte_agent_helm_generated.yaml
+helm template flyte -n flyte ${DIR}/../charts/flyteagent/ ${HELM_CAPABILITIES} --debug > ${DIR}/../deployment/agent/flyte_agent_helm_generated.yaml
 
 
 echo "Generating helm docs"