Add visibility control to dynamic log links (#6000)

* Add visibility control to dynamic log links Signed-off-by: Kevin Su <[email protected]> * Add visibility control to dynamic log links Signed-off-by: Kevin Su <[email protected]> * update logging utils Signed-off-by: Kevin Su <[email protected]> --------- Signed-off-by: Kevin Su <[email protected]>
flyteorg · Nov 15, 2024 · d1a723e · d1a723e
1 parent b3330ba
commit d1a723e
Show file tree

Hide file tree

Showing 3 changed files with 38 additions and 3 deletions.
diff --git a/flyteplugins/go/tasks/logs/logging_utils.go b/flyteplugins/go/tasks/logs/logging_utils.go
@@ -131,6 +131,8 @@ func InitializeLogPlugins(cfg *LogConfig) (tasklog.Plugin, error) {
 				DisplayName:         dynamicLogLink.DisplayName,
 				DynamicTemplateURIs: dynamicLogLink.TemplateURIs,
 				MessageFormat:       core.TaskLog_JSON,
+				ShowWhilePending:    dynamicLogLink.ShowWhilePending,
+				HideOnceFinished:    dynamicLogLink.HideOnceFinished,
 			})
 	}
 

diff --git a/flyteplugins/go/tasks/pluginmachinery/tasklog/template.go b/flyteplugins/go/tasks/pluginmachinery/tasklog/template.go
@@ -219,9 +219,11 @@ func (p TemplateLogPlugin) GetTaskLogs(input Input) (Output, error) {
 					}
 				}
 				taskLogs = append(taskLogs, &core.TaskLog{
-					Uri:           replaceAll(dynamicTemplateURI, templateVars),
-					Name:          p.DisplayName + input.LogName,
-					MessageFormat: p.MessageFormat,
+					Uri:              replaceAll(dynamicTemplateURI, templateVars),
+					Name:             p.DisplayName + input.LogName,
+					MessageFormat:    p.MessageFormat,
+					ShowWhilePending: p.ShowWhilePending,
+					HideOnceFinished: p.HideOnceFinished,
 				})
 			}
 		}

diff --git a/flyteplugins/go/tasks/pluginmachinery/tasklog/template_test.go b/flyteplugins/go/tasks/pluginmachinery/tasklog/template_test.go
@@ -478,6 +478,37 @@ func TestTemplateLogPlugin(t *testing.T) {
 				},
 			},
 		},
+		{
+			"flyteinteractive",
+			TemplateLogPlugin{
+				Name:                "vscode",
+				DynamicTemplateURIs: []TemplateURI{"vscode://flyteinteractive:{{ .taskConfig.port }}/{{ .podName }}"},
+				MessageFormat:       core.TaskLog_JSON,
+				HideOnceFinished:    true,
+				ShowWhilePending:    true,
+			},
+			args{
+				input: Input{
+					PodName: "my-pod-name",
+					TaskTemplate: &core.TaskTemplate{
+						Config: map[string]string{
+							"link_type": "vscode",
+							"port":      "1234",
+						},
+					},
+				},
+			},
+			Output{
+				TaskLogs: []*core.TaskLog{
+					{
+						Uri:              "vscode://flyteinteractive:1234/my-pod-name",
+						MessageFormat:    core.TaskLog_JSON,
+						ShowWhilePending: true,
+						HideOnceFinished: true,
+					},
+				},
+			},
+		},
 		{
 			"flyteinteractive - no link_type in task template",
 			TemplateLogPlugin{