Add LimitRange resource permission to flyteadmin serviceaccount #3969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
mucahitkantepe
changed the title
|
I think it is fair to create this resource- but should we make the RBAC role configurable? |
Signed-off-by: Mücahit Kantepe <[email protected]> Signed-off-by: Mücahit Kantepe <[email protected]>
Signed-off-by: Mücahit Kantepe <[email protected]>
Signed-off-by: Mücahit Kantepe <[email protected]>
mucahitkantepe
force-pushed
the
mucahitkantepe-patch-1
branch
from
86b1209 to
2aad448
Compare
wild-endeavor
approved these changes
Aug 21, 2023
|
Congrats on merging your first pull request! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We deploy use LimitRanges for flyte created namespaces. It would be practical if syncresources can also create this, otherwise we would need to create the rbac resources ourselves