fix(helm): skip redoc when redoc.enabled is set to false #4007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
|
@cmontemuino , thanks for the PR. Can you merge master? That error in the "tests / docs" CI check should be fixed. |
@eapolinario I've just updated my fork 💪 |
The flyte chart includes four templates: minio, postgres, redis, and redoc. A property following the pattern `<template_name>.enabled` does exist in the `values.yaml` file. It is used to enabled/disable the template. Setting `redoc.enabled` to `false` does not disable the `redoc` deployment and service. This changeset fixes that problem by following the same approach with the other templates: wrapping the resoruces under the `templates/redoc` with an `if` statetement evaluating `Values.redoc.enabled`. closes 4006 Signed-off-by: cmontemuino <[email protected]>
dosubot
bot
added
the
size:XS
Signed-off-by: cmontemuino <[email protected]>
|
Hi @eapolinario, is there anything pending as to move this PR forward? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
Closes #4006
Describe your changes
The
flytechart includes four templates: minio, postgres, redis, and redoc. A property following the pattern<template_name>.enableddoes exist in thevalues.yamlfile. It is used to enabled/disable the template.Setting
redoc.enabledtofalsedoes not disable theredocdeployment and service. This changeset fixes that problem by following the same approach with the other templates: wrapping the resoruces under thetemplates/redocwith anifstatetement evaluatingValues.redoc.enabled.Check all the applicable boxes
Screenshots
N/A
Note to reviewers
Steps to reproduce the problem included in #4006