Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run on union-k8s-runner hosted runner #4039

Closed
wants to merge 20 commits into from

Conversation

eapolinario
Copy link
Contributor

Describe your changes

Stacked PR on top of #4014.

In this PR we rename the CI checks to align with the new release process.

eapolinario and others added 19 commits September 7, 2023 17:07
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
* Add dockerfiles

Signed-off-by: Eduardo Apolinario <[email protected]>

* Build component using reusable workflow

Signed-off-by: Eduardo Apolinario <[email protected]>

* Add "Components checks" workflow

Signed-off-by: Eduardo Apolinario <[email protected]>

* Fix typo

Signed-off-by: Eduardo Apolinario <[email protected]>

* Rename gh workflow

Signed-off-by: Eduardo Apolinario <[email protected]>

* Use the correct dockerfile

Signed-off-by: Eduardo Apolinario <[email protected]>

* Enable endtoend tests

Signed-off-by: Eduardo Apolinario <[email protected]>

* Use correct path to end2end reusable workflow

Signed-off-by: Eduardo Apolinario <[email protected]>

* Use unique prefixes for the cache

Signed-off-by: Eduardo Apolinario <[email protected]>

* Use tmp/tmp

Signed-off-by: Eduardo Apolinario <[email protected]>

* Be more explicit about the path components docker images are saved to

Signed-off-by: Eduardo Apolinario <[email protected]>

* Test only overriding datacatalog image

Signed-off-by: Eduardo Apolinario <[email protected]>

* Comment out actual helm upgrades (i.e. simply run tests)

Signed-off-by: Eduardo Apolinario <[email protected]>

* Comment out end2end and bring integration tests

Signed-off-by: Eduardo Apolinario <[email protected]>

* Fix typo in definition of priorities

Signed-off-by: Eduardo Apolinario <[email protected]>

* Hardcode go version to 1.19

Signed-off-by: Eduardo Apolinario <[email protected]>

* Use correct working directory in integration.yml

Signed-off-by: Eduardo Apolinario <[email protected]>

* Enable flytepropeller integration tests

Signed-off-by: Eduardo Apolinario <[email protected]>

* Unpack envvars prior to calling reusable workflow

Signed-off-by: Eduardo Apolinario <[email protected]>

* Enable go_generate.yml

Signed-off-by: Eduardo Apolinario <[email protected]>

* Enable push_docker_image

Signed-off-by: Eduardo Apolinario <[email protected]>

* Fix flytecopilot go generate

Signed-off-by: Eduardo Apolinario <[email protected]>

* Fix image tags

Signed-off-by: Eduardo Apolinario <[email protected]>

* Enable lint and unit tests

Signed-off-by: Eduardo Apolinario <[email protected]>

* Pass component to lint and unit-tests jobs

Signed-off-by: Eduardo Apolinario <[email protected]>

* Fix flytestdlib unit test

Signed-off-by: Eduardo Apolinario <[email protected]>

* Fix flyteplugins test

Signed-off-by: Eduardo Apolinario <[email protected]>

* Build flytescheduler image

Signed-off-by: Eduardo Apolinario <[email protected]>

* Monorepo  ci checks fix lint (#4032)

* Fix flyteplugins lint errors

Signed-off-by: Eduardo Apolinario <[email protected]>

* Fix datacatalog lint errors

Signed-off-by: Eduardo Apolinario <[email protected]>

* Fix flyteadmin lint errors

Signed-off-by: Eduardo Apolinario <[email protected]>

* Fix flyteaidl lint errors

Signed-off-by: Eduardo Apolinario <[email protected]>

* Fix flytepropeller lint errors

Signed-off-by: Eduardo Apolinario <[email protected]>

* Comment flytecopilot lint and flyteidl unit tests

Signed-off-by: Eduardo Apolinario <[email protected]>

---------

Signed-off-by: Eduardo Apolinario <[email protected]>
Co-authored-by: Eduardo Apolinario <[email protected]>

---------

Signed-off-by: Eduardo Apolinario <[email protected]>
Co-authored-by: Eduardo Apolinario <[email protected]>
* Fix single-binary

Signed-off-by: Eduardo Apolinario <[email protected]>

* Fix flyteplugins references in single-binary

Signed-off-by: Eduardo Apolinario <[email protected]>

* Point to local flyteidl in single-binary

Signed-off-by: Eduardo Apolinario <[email protected]>

* Fix flytecopilot references

Signed-off-by: Eduardo Apolinario <[email protected]>

---------

Signed-off-by: Eduardo Apolinario <[email protected]>
Co-authored-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.31% 🎉

Comparison is base (4fdf255) 58.90% compared to head (fed871c) 59.22%.

❗ Current head fed871c differs from pull request most recent head cd1bd25. Consider uploading reports for the commit cd1bd25 to get more accurate results

Additional details and impacted files
@@                             Coverage Diff                             @@
##           monorepo--rename-modules-and-go-replace    #4039      +/-   ##
===========================================================================
+ Coverage                                    58.90%   59.22%   +0.31%     
===========================================================================
  Files                                          618      549      -69     
  Lines                                        52575    39512   -13063     
===========================================================================
- Hits                                         30969    23400    -7569     
+ Misses                                       19141    13810    -5331     
+ Partials                                      2465     2302     -163     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 554 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from monorepo--rename-modules-and-go-replace to master September 25, 2023 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant