-
Notifications
You must be signed in to change notification settings - Fork 660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flyte Add Enable/Disable Options for Agent Services #4041
Flyte Add Enable/Disable Options for Agent Services #4041
Conversation
Signed-off-by: Future Outlier <[email protected]>
docker/sandbox-bundled/kustomize/complete-agent/kustomization.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: Future Outlier <[email protected]>
Signed-off-by: Future Outlier <[email protected]>
Signed-off-by: Future Outlier <[email protected]>
Signed-off-by: Future Outlier <[email protected]>
Signed-off-by: Future Outlier <[email protected]>
Hello Reviewers, I appreciate @pingsutw's suggestion; it's quite insightful! I learned a lot! For someone who's new or at the entry level, I believe enhancing the key agent-service structure would make it more user-friendly. Consider the transition: Current Configuration: agent-service:
defaultAgent:
endpoint: "dns:///flyteagent.flyte.svc.cluster.local:8000"
insecure: true Proposed Configuration: agent-service:
defaultAgent:
endpoint: "dns:///flyteagent.flyte.svc.cluster.local:8000"
insecure: true
timeouts:
GetTask: 100s
defaultTimeout: 100s
agents:
custom_agent:
endpoint: "dns:///flyteagent.flyte.svc.cluster.local:8001"
insecure: false
defaultServiceConfig: '{"loadBalancingConfig": [{"round_robin":{}}]}'
timeouts:
GetTask: 100s
defaultTimeout: 100s
agentForTaskTypes:
# Overrides the default agent for custom_task. This means propeller will send the request to this agent.
- custom_task: custom_agent I'm eager to hear your thoughts on this. Thanks a lot! |
Signed-off-by: Future Outlier <[email protected]>
After a discussion with pingsu, we decide to left
like this! |
Signed-off-by: Future Outlier <[email protected]>
… flytectl-enable-agent
Signed-off-by: Future Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
… flytectl-enable-agent
…lier/flyte into flytectl-enable-agent
Signed-off-by: Future Outlier <[email protected]>
@pingsutw @jeevb Please take a look, and approve the PR here: flyteorg/flytectl#420 |
… flytectl-enable-agent
Signed-off-by: Future Outlier <[email protected]>
Signed-off-by: Future Outlier <[email protected]>
TL;DR
Describe your changes
@pingsutw and I have introduced two options for users to configure the Flyte agent - it can now be either enabled or disabled.
We believe this enhancement will offer more flexibility and cater to diverse user needs and deployment scenarios.
After a thorough consideration, we have decided to set the "enable agent" option as the default setting.
Enable agent service (Default)
Enable the agent deployment by updating helm and kustomization.
You can use my image on the docker hub to test.
Disable agent service (Use flag)
Tracking issue
#3936
flyteorg/flytectl#420
Check all the applicable boxes
Screen Shot
New Pod Addition: The newly introduced pod is named "flyteagent". You can view the snapshot of its presence here.
Config Map Update: The "flyte-sandbox-config" config map situated in the "flyte" namespace has been updated.
Its current snapshot can be viewed here.
Notably, there's an addition of the
enabled-plugins
key, which can be viewed here.