Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Monorepo] Bump flytepropeller to v1.1.129 #4123

Merged
merged 6 commits into from
Oct 3, 2023

Conversation

eapolinario
Copy link
Contributor

Describe your changes

As PR title says. This PR brings flytepropeller to v1.1.129.

EngHabu and others added 6 commits September 25, 2023 17:45
* Update plugins

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* empty

Signed-off-by: Haytham Abuelfutuh <[email protected]>

* Update to latest plugins

Signed-off-by: Haytham Abuelfutuh <[email protected]>

---------

Signed-off-by: Haytham Abuelfutuh <[email protected]>
* wip: Add k8s events to task phase updates

Signed-off-by: Andrew Dye <[email protected]>

* Refactor clientset, pluginstate

Signed-off-by: Andrew Dye <[email protected]>

* Refactor to use batched events

Signed-off-by: Andrew Dye <[email protected]>

* go.mod updates

Signed-off-by: Andrew Dye <[email protected]>

* Linits

Signed-off-by: Andrew Dye <[email protected]>

* Update flyteidl and flyteplugins versions

Signed-off-by: Andrew Dye <[email protected]>

* Update to EventReason

Signed-off-by: Andrew Dye <[email protected]>

* Comments

Signed-off-by: Andrew Dye <[email protected]>

* Readd GroupVersionKind changes

Signed-off-by: Andrew Dye <[email protected]>

---------

Signed-off-by: Andrew Dye <[email protected]>
…norepo--bump-flytepropeller-to-v1.1.129

Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Attention: 52 lines in your changes are missing coverage. Please review.

Comparison is base (b35cc95) 58.98% compared to head (b3ed285) 59.31%.

❗ Current head b3ed285 differs from pull request most recent head d317e1f. Consider uploading reports for the commit d317e1f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4123      +/-   ##
==========================================
+ Coverage   58.98%   59.31%   +0.33%     
==========================================
  Files         618      550      -68     
  Lines       52708    39693   -13015     
==========================================
- Hits        31088    23545    -7543     
+ Misses      19140    13828    -5312     
+ Partials     2480     2320     -160     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ropeller/pkg/controller/executors/dag_structure.go 100.00% <ø> (ø)
...ller/pkg/controller/executors/execution_context.go 58.06% <ø> (-0.76%) ⬇️
flytepropeller/pkg/controller/executors/kube.go 37.93% <ø> (+1.81%) ⬆️
...epropeller/pkg/controller/executors/node_lookup.go 77.77% <ø> (-2.23%) ⬇️
...lytepropeller/pkg/controller/nodes/task/handler.go 60.55% <100.00%> (+1.90%) ⬆️
...opeller/pkg/controller/nodes/task/plugin_config.go 94.59% <100.00%> (+1.41%) ⬆️
flytepropeller/pkg/controller/controller.go 11.56% <0.00%> (-0.19%) ⬇️
...propeller/pkg/controller/nodes/task/transformer.go 79.31% <61.11%> (+2.44%) ⬆️
...ler/pkg/controller/nodes/task/k8s/event_watcher.go 77.77% <77.77%> (ø)
...er/pkg/controller/nodes/task/k8s/plugin_manager.go 53.20% <59.15%> (-1.16%) ⬇️

... and 546 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eapolinario eapolinario merged commit d9586b0 into master Oct 3, 2023
36 checks passed
@eapolinario eapolinario deleted the monorepo--bump-flytepropeller-to-v1.1.129 branch October 3, 2023 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants