Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip - Move flytekit to monorepo #4923

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

eapolinario
Copy link
Contributor

@eapolinario eapolinario commented Feb 21, 2024

Tracking issue

NA

Why are the changes needed?

Prior to this PR, changes in flytekit that require an updated flyteidl need to happen in 2 steps: (1) pin flyteidl in flytekit to a SHA, and once flyteidl is released (2) pin flyteidl version in flytekit to the released version.

What changes were proposed in this pull request?

Move flytekit to the monorepo.

As mentioned in the title, this is wip as there are a bunch of open questions, including:

  1. how this affects the release process
  2. changes to monodocs
  3. the relevant generated code (i.e. the code under flyteidl/gen/pb_python is symlinked).
    i. I couldn't figure out how to specify a path to a relative dependency in pip. According to https://stackoverflow.com/questions/75159453/specifying-local-relative-dependency-in-pyproject-toml, pip doesn't have support for this. Other package managers like poetry, pdm, and hatch do.

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. enhancement New feature or request housekeeping Issues that help maintain flyte and keep it tech-debt free labels Feb 21, 2024
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.96%. Comparing base (e39acc7) to head (0c6a808).
Report is 10 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4923      +/-   ##
==========================================
+ Coverage   58.91%   58.96%   +0.04%     
==========================================
  Files         645      645              
  Lines       55412    55506      +94     
==========================================
+ Hits        32648    32731      +83     
+ Misses      20181    20177       -4     
- Partials     2583     2598      +15     
Flag Coverage Δ
unittests 58.96% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request housekeeping Issues that help maintain flyte and keep it tech-debt free size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant