-
Notifications
You must be signed in to change notification settings - Fork 660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add variables to ease separate bucket config #5015
Merged
davidmirror-ops
merged 11 commits into
flyteorg:master
from
davidmirror-ops:4291-separate-buckets
Apr 1, 2024
Merged
Add variables to ease separate bucket config #5015
davidmirror-ops
merged 11 commits into
flyteorg:master
from
davidmirror-ops:4291-separate-buckets
Apr 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:S
This PR changes 10-29 lines, ignoring generated files.
enhancement
New feature or request
labels
Mar 6, 2024
Signed-off-by: davidmirror-ops <david [email protected]>
davidmirror-ops
force-pushed
the
4291-separate-buckets
branch
from
March 6, 2024 17:45
03badc2
to
6e415a0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5015 +/- ##
==========================================
- Coverage 59.11% 59.10% -0.02%
==========================================
Files 645 645
Lines 55574 55574
==========================================
- Hits 32852 32846 -6
- Misses 20129 20135 +6
Partials 2593 2593
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: davidmirror-ops <david [email protected]>
dosubot
bot
added
size:XXL
This PR changes 1000+ lines, ignoring generated files.
and removed
size:S
This PR changes 10-29 lines, ignoring generated files.
labels
Mar 6, 2024
Signed-off-by: David Espejo <[email protected]>
dosubot
bot
added
size:L
This PR changes 100-499 lines, ignoring generated files.
and removed
size:XXL
This PR changes 1000+ lines, ignoring generated files.
labels
Mar 11, 2024
Signed-off-by: David Espejo <[email protected]>
dosubot
bot
added
size:M
This PR changes 30-99 lines, ignoring generated files.
and removed
size:L
This PR changes 100-499 lines, ignoring generated files.
labels
Mar 13, 2024
Signed-off-by: davidmirror-ops <david [email protected]>
dosubot
bot
added
size:L
This PR changes 100-499 lines, ignoring generated files.
and removed
size:M
This PR changes 30-99 lines, ignoring generated files.
labels
Mar 13, 2024
Signed-off-by: David Espejo <[email protected]>
Signed-off-by: David Espejo <[email protected]>
dosubot
bot
added
size:M
This PR changes 30-99 lines, ignoring generated files.
and removed
size:L
This PR changes 100-499 lines, ignoring generated files.
labels
Mar 21, 2024
Signed-off-by: davidmirror-ops <david [email protected]>
dosubot
bot
added
size:L
This PR changes 100-499 lines, ignoring generated files.
and removed
size:M
This PR changes 30-99 lines, ignoring generated files.
labels
Mar 21, 2024
Signed-off-by: David Espejo <[email protected]>
Signed-off-by: davidmirror-ops <david [email protected]>
Signed-off-by: David Espejo <[email protected]>
dosubot
bot
removed
the
size:L
This PR changes 100-499 lines, ignoring generated files.
label
Apr 1, 2024
dosubot
bot
added
the
size:M
This PR changes 30-99 lines, ignoring generated files.
label
Apr 1, 2024
pingsutw
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
lgtm
This PR has been approved by a maintainer
size:M
This PR changes 30-99 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
Closes #4291
Why are the changes needed?
Closing #4759 in favor of this simpler implementation achieving the same goal.
What changes were proposed in this pull request?
How was this patch tested?
Deployed on a live EKS cluster,a wf execution correctly stored closure on metadata bucket and offloaded outputs to user bucket.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link