Upgrade lestrrat-go/jwx to v1.2.29 #5141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:M
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5141 +/- ##
==========================================
- Coverage 60.06% 59.11% -0.96%
==========================================
Files 463 645 +182
Lines 38884 55574 +16690
==========================================
+ Hits 23357 32852 +9495
- Misses 13687 20129 +6442
- Partials 1840 2593 +753
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ddl-ebrown
force-pushed
the
upgrade-lestrrat-go
branch
from
10e88e7
to
4fa4186
Compare
dosubot
bot
added
size:L
|
Looks like this one is going to require some test fixes UPDATE: ran this test locally in isolation and it passed. I think there might be some shared state / test races / timing issues somewhere. |
ddl-ebrown
force-pushed
the
upgrade-lestrrat-go
branch
2 times, most recently
from
d2d609d
to
c851a1b
Compare
|
Test fails are gone now in CI - think it was an unrelated intermittent fail. I've updated everything against master so I think this one is good now @eapolinario |
pingsutw
previously approved these changes
Mar 29, 2024
ddl-ebrown
force-pushed
the
upgrade-lestrrat-go
branch
from
c851a1b
to
b27a20c
Compare
ddl-ebrown
changed the title
ddl-ebrown
force-pushed
the
upgrade-lestrrat-go
branch
2 times, most recently
from
42fe6cb
to
23ad80a
Compare
dosubot
bot
added
size:M
ddl-ebrown
force-pushed
the
upgrade-lestrrat-go
branch
2 times, most recently
from
b636d3c
to
8db5163
Compare
- go get -u github.com/lestrrat-go/jwx Resolves a number of vulnerabilities including: CVE-2024-28122 medium CVE-2024-21664 high CVE-2023-49290 medium CVE-2024-28122 medium Signed-off-by: ddl-ebrown <[email protected]>
ddl-ebrown
force-pushed
the
upgrade-lestrrat-go
branch
from
8db5163
to
45d8f28
Compare
pingsutw
approved these changes
Apr 3, 2024
eapolinario
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
https://github.com/flyteorg/flyte/issues/
Why are the changes needed?
Resolves vulnerabilities
What changes were proposed in this pull request?
go get -u github.com/lestrrat-go/jwx
Resolves the vulnerabilities
GHSA-hj3v-m684-v259 medium
GHSA-pvcr-v8j8-j5q3 high
GHSA-7f9x-gw85-8grf medium
GHSA-hj3v-m684-v259 medium
How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link