Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flyte-core] Add tolerations and affinity for missing deployments #5386

Conversation

jo-gre
Copy link

@jo-gre jo-gre commented May 17, 2024

Why are the changes needed?

This allows the chart to create all deployments on a tainted node. Without this, it is not possible to run the entire flyte-core chart on a node that has a taint.

What changes were proposed in this pull request?

This PR adds tolerations and affinity to the deployments flyte-pod-webhook and syncresources.

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Copy link

welcome bot commented May 17, 2024

Thank you for opening this pull request! 🙌

These tips will help get your PR across the finish line:

  • Most of the repos have a PR template; if not, fill it out to the best of your knowledge.
  • Sign off your commits (Reference: DCO Guide).

@jo-gre jo-gre force-pushed the feature/add-tolerations-to-webhoook-and-syncresources branch from a63048b to 997df11 Compare May 17, 2024 18:20
@jo-gre jo-gre changed the title Feature/add tolerations to webhoook and syncresources [flyte-core] Add tolerations and affinity for missing deployments May 17, 2024
Copy link

codecov bot commented Jun 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.07%. Comparing base (2f1f813) to head (997df11).
Report is 292 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5386      +/-   ##
==========================================
- Coverage   61.08%   61.07%   -0.02%     
==========================================
  Files         793      793              
  Lines       51156    51156              
==========================================
- Hits        31251    31245       -6     
- Misses      17033    17039       +6     
  Partials     2872     2872              
Flag Coverage Δ
unittests-datacatalog 69.31% <ø> (ø)
unittests-flyteadmin 58.82% <ø> (-0.05%) ⬇️
unittests-flytecopilot 17.79% <ø> (ø)
unittests-flytectl 68.31% <ø> (ø)
unittests-flyteidl 79.30% <ø> (ø)
unittests-flyteplugins 61.94% <ø> (ø)
unittests-flytepropeller 57.32% <ø> (ø)
unittests-flytestdlib 65.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@davidmirror-ops davidmirror-ops self-requested a review June 20, 2024 10:32
@jo-gre jo-gre closed this Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant