Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix doc link to testing agent on local cluster #5398

Merged
merged 1 commit into from
May 21, 2024

Conversation

Sovietaced
Copy link
Contributor

@Sovietaced Sovietaced commented May 20, 2024

Signed-off-by: Jason Parraga <[email protected]>
@Sovietaced Sovietaced changed the title Fix doc link to test on local cluster Fix doc link to testing agent on local cluster May 20, 2024
Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.23%. Comparing base (16d2b14) to head (1b14be4).
Report is 134 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5398      +/-   ##
==========================================
- Coverage   61.07%   60.23%   -0.84%     
==========================================
  Files         793      646     -147     
  Lines       51210    45691    -5519     
==========================================
- Hits        31274    27522    -3752     
+ Misses      17060    15575    -1485     
+ Partials     2876     2594     -282     
Flag Coverage Δ
unittests-datacatalog 69.31% <ø> (ø)
unittests-flyteadmin 58.90% <ø> (ø)
unittests-flytecopilot 17.79% <ø> (ø)
unittests-flytectl ?
unittests-flyteidl 79.04% <ø> (ø)
unittests-flyteplugins 61.94% <ø> (ø)
unittests-flytepropeller 57.32% <ø> (ø)
unittests-flytestdlib 65.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sovietaced
Copy link
Contributor Author

Seems that the build failures should be unrelated to the doc update

@neverett
Copy link
Contributor

@Sovietaced yeah, those failures are unrelated

@neverett neverett merged commit cfaedce into flyteorg:master May 21, 2024
48 of 50 checks passed
robert-ulbrich-mercedes-benz pushed a commit to robert-ulbrich-mercedes-benz/flyte that referenced this pull request Jul 2, 2024
Signed-off-by: Jason Parraga <[email protected]>
Co-authored-by: Jason Parraga <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants