Feat: Allow using in-cluster creds in control plane cluster in a multi-cluster deployment #5403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r deployment Signed-off-by: Fabio Graetz <[email protected]>
Signed-off-by: Fabio Graetz <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5403 +/- ##
=======================================
Coverage 61.07% 61.07%
=======================================
Files 793 793
Lines 51210 51210
=======================================
+ Hits 31274 31275 +1
+ Misses 17060 17059 -1
Partials 2876 2876
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
wild-endeavor
approved these changes
Jun 5, 2024
robert-ulbrich-mercedes-benz
pushed a commit
to robert-ulbrich-mercedes-benz/flyte
that referenced
this pull request
Jul 2, 2024
…i-cluster deployment (flyteorg#5403) * Allow using in-cluster creds in control plane cluster in multi-cluster deployment Signed-off-by: Fabio Graetz <[email protected]> * Check inCluster flag in cluster config test Signed-off-by: Fabio Graetz <[email protected]> --------- Signed-off-by: Fabio Graetz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
When configuring a Flyte multi-cluster deployment, one might want to use the control plane cluster also to schedule workflows.
Currently, flyteadmin is not able to use in-cluster credentials for this use case. Instead, one has to go through the much more cumbersome credentials configuration process required for data plane clusters (see here).
This PR allows flyteadmin to just use in-cluster credentials instead.
As briefly discussed in the last contributors' sync @wild-endeavor.
How was this patch tested?
Check all the applicable boxes
Docs link