Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Improve execution name readability" #5740

Merged
merged 5 commits into from
Sep 26, 2024

merged master

193c662
Select commit
Loading
Failed to load commit list.
Merged

Revert "Improve execution name readability" #5740

merged master
193c662
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 26, 2024 in 1s

36.31% (+1.87%) compared to c01a059

View this Pull Request on Codecov

36.31% (+1.87%) compared to c01a059

Details

Codecov Report

Attention: Patch coverage is 76.92308% with 3 lines in your changes missing coverage. Please review.

Project coverage is 36.31%. Comparing base (c01a059) to head (193c662).

Files with missing lines Patch % Lines
flyteadmin/scheduler/executor/executor_impl.go 50.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5740      +/-   ##
==========================================
+ Coverage   34.44%   36.31%   +1.87%     
==========================================
  Files        1139     1304     +165     
  Lines      102613   110016    +7403     
==========================================
+ Hits        35341    39948    +4607     
- Misses      63609    65911    +2302     
- Partials     3663     4157     +494     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.