Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the documentation about uniqueness of execution IDs #5828

Merged

Conversation

Murdock9803
Copy link
Contributor

@Murdock9803 Murdock9803 commented Oct 9, 2024

Tracking issue

Closes #4684

Why are the changes needed?

The executions has documentation about Execution and their Typical Flow. As suggested in issue #4684, there should be information about the execution IDs as well.

What changes were proposed in this pull request?

The PR simply adds an additional line in the documentation about execution IDs.

How was this patch tested?

This was a simple and straightforward Doc change, so right syntax is kept in mind and checked.

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

@Murdock9803 Murdock9803 changed the title added the documentation about uniqueness of execution IDs in a projec… Added the documentation about uniqueness of execution IDs Oct 9, 2024
@Murdock9803
Copy link
Contributor Author

@davidmirror-ops @samhita-alla I tried to incorporate the required changes, should I change the position of added text or anything ? Please have a look at the Pull Request 🙌

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.70%. Comparing base (604be4a) to head (2d0ac2d).
Report is 15 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5828      +/-   ##
==========================================
- Coverage   36.35%   34.70%   -1.66%     
==========================================
  Files        1304      991     -313     
  Lines      110147    85287   -24860     
==========================================
- Hits        40041    29595   -10446     
+ Misses      65939    52753   -13186     
+ Partials     4167     2939    -1228     
Flag Coverage Δ
unittests-datacatalog 51.37% <ø> (ø)
unittests-flyteadmin 55.60% <ø> (ø)
unittests-flytecopilot 12.17% <ø> (ø)
unittests-flytectl 62.21% <ø> (ø)
unittests-flyteidl 7.17% <ø> (ø)
unittests-flyteplugins 53.35% <ø> (ø)
unittests-flytepropeller ?
unittests-flytestdlib 55.37% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidmirror-ops davidmirror-ops enabled auto-merge (squash) October 9, 2024 22:38
@davidmirror-ops davidmirror-ops merged commit 197ae13 into flyteorg:master Oct 9, 2024
49 of 50 checks passed
Copy link

welcome bot commented Oct 9, 2024

Congrats on merging your first pull request! 🎉

@Murdock9803
Copy link
Contributor Author

I am really grateful to have my first PR merged at this organization, and excited for future ones 🙌 ❤️

@davidmirror-ops
Copy link
Contributor

@Murdock9803 remember to fill out this form before Oct 31 to register your contributions for swag. Thank you!

@Murdock9803 Murdock9803 deleted the executionID-doc-update branch October 15, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs] document that execution IDs are unique within a project-domain
3 participants