Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Union type with dataclass ambiguous error and support superset comparison #5858

Merged
merged 30 commits into from
Nov 20, 2024

Reviews from Eduardo

ada05ed
Select commit
Loading
Failed to load commit list.
Merged

Fix Union type with dataclass ambiguous error and support superset comparison #5858

Reviews from Eduardo
ada05ed
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Nov 11, 2024 in 0s

64.76% of diff hit (target 36.90%)

View this Pull Request on Codecov

64.76% of diff hit (target 36.90%)

Annotations

Check warning on line 27 in flytepropeller/pkg/compiler/validators/typing.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flytepropeller/pkg/compiler/validators/typing.go#L26-L27 

Added lines #L26 - L27 were not covered by tests

Check warning on line 47 in flytepropeller/pkg/compiler/validators/typing.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flytepropeller/pkg/compiler/validators/typing.go#L37-L47 

Added lines #L37 - L47 were not covered by tests

Check warning on line 50 in flytepropeller/pkg/compiler/validators/typing.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flytepropeller/pkg/compiler/validators/typing.go#L50 

Added line #L50 was not covered by tests

Check warning on line 62 in flytepropeller/pkg/compiler/validators/typing.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flytepropeller/pkg/compiler/validators/typing.go#L61-L62 

Added lines #L61 - L62 were not covered by tests

Check warning on line 78 in flytepropeller/pkg/compiler/validators/typing.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flytepropeller/pkg/compiler/validators/typing.go#L77-L78 

Added lines #L77 - L78 were not covered by tests

Check warning on line 81 in flytepropeller/pkg/compiler/validators/typing.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flytepropeller/pkg/compiler/validators/typing.go#L80-L81 

Added lines #L80 - L81 were not covered by tests

Check warning on line 98 in flytepropeller/pkg/compiler/validators/typing.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flytepropeller/pkg/compiler/validators/typing.go#L95-L98 

Added lines #L95 - L98 were not covered by tests

Check warning on line 101 in flytepropeller/pkg/compiler/validators/typing.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flytepropeller/pkg/compiler/validators/typing.go#L101 

Added line #L101 was not covered by tests

Check warning on line 104 in flytepropeller/pkg/compiler/validators/typing.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flytepropeller/pkg/compiler/validators/typing.go#L103-L104 

Added lines #L103 - L104 were not covered by tests

Check warning on line 118 in flytepropeller/pkg/compiler/validators/typing.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flytepropeller/pkg/compiler/validators/typing.go#L117-L118 

Added lines #L117 - L118 were not covered by tests
View more details on Codecov