-
Notifications
You must be signed in to change notification settings - Fork 660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Union type with dataclass ambiguous error and support superset comparison #5858
Merged
Future-Outlier
merged 30 commits into
flyteorg:master
from
mao3267:fix/#5489-dataclass-mismatch
Nov 20, 2024
Merged
Changes from 28 commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
f06cdc6
feat: fix Union type with dataclass ambiguous error
mao3267 8660db5
Merge branch 'master' of https://github.com/mao3267/flyte into fix/#5…
mao3267 47ccbd1
fix: direct json comparison for superset
mao3267 85489dc
fix: go.mod missing entry for error
mao3267 cc685bb
fix: update go module and sum
mao3267 3a629e1
refactor: gci format
mao3267 aa4d98e
test: add dataset casting tests for same (one/two levels) and supers…
mao3267 b282e5f
Merge branch 'master' of https://github.com/mao3267/flyte into fix/#5…
mao3267 818afb7
fix: support Pydantic BaseModel comparison
mao3267 d6468b6
fix: handle nested pydantic basemodel
mao3267 ada05ed
Reviews from Eduardo
Future-Outlier 56623e3
fix: support strict subset match
mao3267 b8f38a7
test: update strict subset match test
mao3267 b698769
fix: missing go mod entry
mao3267 70ad767
fix: missing go mod entry
mao3267 9dc3fa6
fix: go mod entry
mao3267 b224a02
make go-tidy
Future-Outlier 7ed9be2
comments
Future-Outlier 6fe8871
Merge branch 'fix/#5489-dataclass-mismatch' of https://github.com/mao…
mao3267 64343c8
fix: strict subset match with draft 2020-12 mashumaro
mao3267 8ccced5
Merge branch 'master' of https://github.com/mao3267/flyte into fix/#5…
mao3267 0def0ad
refactor: make go-tidy
mao3267 81445a7
fix: support strict subset match with ambiguity
mao3267 9b19f04
fix: change test name and fix err
mao3267 30aa096
Add comments
Future-Outlier e62ba6e
nit
Future-Outlier c6ac729
add flytectl go-tidy in makefile
Future-Outlier ba4d6f1
nit
Future-Outlier 86a395e
fix: add comment for error checking
mao3267 7f28c35
test: basemodel castable test, two level dataclass and ParentToChild …
mao3267 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
santhosh-tekuri/jsonschema"
uses Apache License.wI2L/jsondiff
uses MIT License.yvesf/json-schema-compare
uses LGPL License.