-
Notifications
You must be signed in to change notification settings - Fork 660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: customize demo cluster port #5969
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Vincent <[email protected]>
Signed-off-by: Vincent <[email protected]>
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
Can you also modify the creation of the kubeconfig file to point to this new port? Trace uses of https://github.com/flyteorg/flyte/blob/master/flytectl/pkg/docker/docker_util.go#L31 As part of initializing the sandbox we write a kubeconfig file that simplifies access to the cluster. That |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5969 +/- ##
==========================================
+ Coverage 36.86% 37.04% +0.18%
==========================================
Files 1310 1318 +8
Lines 131246 132252 +1006
==========================================
+ Hits 48380 48989 +609
- Misses 78668 79004 +336
- Partials 4198 4259 +61
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Co-authored-by: Kevin Su <[email protected]> Signed-off-by: 0xffv <[email protected]>
Signed-off-by: Vincent <[email protected]>
Tracking issue
Closes #3792
Why are the changes needed?
As stated in [Flytectl Feature] flytectl demo cluster - configurable port number #3792, when a developer uses Docker Desktop with Kubernetes running on port 6443, they must shut it down before running the demo cluster
Allow users to configure the demo cluster port if needed
What changes were proposed in this pull request?
port
, e.g.,flytectl demo start --port 6443
sandbox_config.go
instead of using fixed onesreload.go
to retrieve sandbox config (follow other file structure underflyte/flytectl/cmd/demo
)How was this patch tested?
Tested that parameters were automatically generated with
make generate
Setup process
kubectl --server=https://localhost:6444 get pods
export FLYTECTL_CONFIG= ~/<pathTo>/.flyte/config-sandbox.yaml
pyflyte run --remote
Screenshots
Check all the applicable boxes
Related PRs
Docs link