Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark execution mode enum reserved #6040

Merged
merged 2 commits into from
Nov 25, 2024
Merged

Conversation

katrogan
Copy link
Contributor

Why are the changes needed?

What changes were proposed in this pull request?

see PR title

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.04%. Comparing base (6f187ae) to head (6dbd5d9).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6040      +/-   ##
==========================================
- Coverage   37.05%   37.04%   -0.01%     
==========================================
  Files        1316     1316              
  Lines      132247   132247              
==========================================
- Hits        48998    48991       -7     
- Misses      78987    78994       +7     
  Partials     4262     4262              
Flag Coverage Δ
unittests-datacatalog 51.58% <ø> (ø)
unittests-flyteadmin 54.07% <ø> (-0.03%) ⬇️
unittests-flytecopilot 22.23% <ø> (ø)
unittests-flytectl 62.46% <ø> (ø)
unittests-flyteidl 7.24% <ø> (ø)
unittests-flyteplugins 53.73% <ø> (ø)
unittests-flytepropeller 42.63% <ø> (ø)
unittests-flytestdlib 57.57% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@katrogan katrogan marked this pull request as ready for review November 25, 2024 16:27
@eapolinario eapolinario enabled auto-merge (squash) November 25, 2024 16:29
@eapolinario eapolinario merged commit 4071212 into master Nov 25, 2024
50 of 52 checks passed
@eapolinario eapolinario deleted the katrina/cor-2229-enum-reserved branch November 25, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants