Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Enable flytekit to authenticate with proxy in front of FlyteAdmin #1787

Merged
merged 24 commits into from
Sep 20, 2023
Merged

Feat: Enable flytekit to authenticate with proxy in front of FlyteAdmin #1787

merged 24 commits into from
Sep 20, 2023

Commits on Aug 25, 2023

  1. Introduce authenticator engine and make proxy auth work 

    Signed-off-by: Fabio Grätz <[email protected]>
    Fabio Grätz committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    2794d00 View commit details
    Browse the repository at this point in the history

  2. Use proxy authed session for client credentials flow 

    Signed-off-by: Fabio Grätz <[email protected]>
    Fabio Grätz committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    5d157e9 View commit details
    Browse the repository at this point in the history

  3. Don't use authenticator engine but do proxy authentication via existi… 

    …ng external command authenticator

Signed-off-by: Fabio Grätz <[email protected]>
    Fabio Grätz committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    125a7ee View commit details
    Browse the repository at this point in the history

  4. Add docstring to AuthenticationHTTPAdapter 

    Signed-off-by: Fabio Grätz <[email protected]>
    Fabio Grätz committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    ad8d556 View commit details
    Browse the repository at this point in the history

  5. Address todo in docstring 

    Signed-off-by: Fabio Grätz <[email protected]>
    Fabio Grätz committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    e0d0de9 View commit details
    Browse the repository at this point in the history

  6. Create blank session if none provided 

    Signed-off-by: Fabio Grätz <[email protected]>
    Fabio Grätz committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    fc393a3 View commit details
    Browse the repository at this point in the history

  7. Create blank session if none provided in get_token 

    Signed-off-by: Fabio Grätz <[email protected]>
    Fabio Grätz committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    21710e0 View commit details
    Browse the repository at this point in the history

  8. Refresh proxy creds in session when not existing without triggering 401 

    Signed-off-by: Fabio Grätz <[email protected]>
    Fabio Grätz committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    397654c View commit details
    Browse the repository at this point in the history

  9. Add test for get_session 

    Signed-off-by: Fabio Grätz <[email protected]>
    Fabio Grätz committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    6902036 View commit details
    Browse the repository at this point in the history

  10. Move auth helper test into existing module 

    Signed-off-by: Fabio Grätz <[email protected]>
    Fabio Grätz committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    977163d View commit details
    Browse the repository at this point in the history

  11. Move auth helper test into existing module 

    Signed-off-by: Fabio Grätz <[email protected]>
    Fabio Grätz committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    eda1805 View commit details
    Browse the repository at this point in the history

  12. Add test for upgrade_channel_to_proxy_authenticated 

    Signed-off-by: Fabio Grätz <[email protected]>
    Fabio Grätz committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    79b9dae View commit details
    Browse the repository at this point in the history

  13. Auth helper tests without use of responses package 

    Signed-off-by: Fabio Grätz <[email protected]>
    Fabio Grätz committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    40378c1 View commit details
    Browse the repository at this point in the history

  14. Feat: Add plugin for generating GCP IAP ID tokens via external command ( 

    #1795)

* Add external command plugin to generate id tokens for identity aware proxy

Signed-off-by: Fabio Grätz <[email protected]>

* Retrieve desktop app client secret from gcp secret manager

Signed-off-by: Fabio Grätz <[email protected]>

* Remove comments

Signed-off-by: Fabio Grätz <[email protected]>

* Introduce a command group that allows adding a command to generate service account id tokens later

Signed-off-by: Fabio Grätz <[email protected]>

* Document how to use plugin and deploy Flyte with IAP

Signed-off-by: Fabio Grätz <[email protected]>

* Minor corrections README.md

Signed-off-by: Fabio Grätz <[email protected]>

---------

Signed-off-by: Fabio Grätz <[email protected]>
Co-authored-by: Fabio Grätz <[email protected]>
Signed-off-by: Fabio Grätz <[email protected]>
    @fg91
    fg91 and Fabio Grätz committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    085319d View commit details
    Browse the repository at this point in the history

  15. Use proxy auth'ed session for device code auth flow 

    Signed-off-by: Fabio Grätz <[email protected]>
    Fabio Grätz committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    a237066 View commit details
    Browse the repository at this point in the history

  16. Fix token client tests 

    Signed-off-by: Fabio Grätz <[email protected]>
    Fabio Grätz committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    caa3653 View commit details
    Browse the repository at this point in the history

  17. Make poll token endpoint test more specific 

    Signed-off-by: Fabio Grätz <[email protected]>
    Fabio Grätz committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    2ebad82 View commit details
    Browse the repository at this point in the history

  18. Make test_client_creds_authenticator test work and more specific 

    Signed-off-by: Fabio Grätz <[email protected]>
    Fabio Grätz committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    f9ddc8c View commit details
    Browse the repository at this point in the history

  19. Make test_client_creds_authenticator_with_custom_scopes test work and… 

    … more specific

Signed-off-by: Fabio Grätz <[email protected]>
    Fabio Grätz committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    c677ff3 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2023

  1. Implement subcommand to generate id tokens for service accounts 

    Signed-off-by: Fabio Graetz <[email protected]>
    @fg91
    fg91 committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    336aebc View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2023

  1. Test id token generation from service accounts 

    Signed-off-by: Fabio Graetz <[email protected]>
    @fg91
    fg91 committed Sep 9, 2023
    Configuration menu
    Copy the full SHA
    7ad826d View commit details
    Browse the repository at this point in the history

  2. Fix plugin requirements 

    Signed-off-by: Fabio Graetz <[email protected]>
    @fg91
    fg91 committed Sep 9, 2023
    Configuration menu
    Copy the full SHA
    b35988a View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2023

  1. Document usage of generate-service-account-id-token subcommand 

    Signed-off-by: Fabio Grätz <[email protected]>
    Fabio Grätz committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    a713c56 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2023

  1. Document alternative ways to obtain service account id tokens 

    Signed-off-by: Fabio Grätz <[email protected]>
    Fabio Grätz committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    2437b84 View commit details
    Browse the repository at this point in the history