Fix [BUG] Module 'PIL' has no attribute Image #1793
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Future Outlier <[email protected]>
Signed-off-by: Future Outlier <[email protected]>
Signed-off-by: Future Outlier <[email protected]>
Signed-off-by: Future Outlier <[email protected]>
…/github.com/Future-Outlier/flytekit into add-type-annotations-for-configuration-file
Signed-off-by: Future Outlier <[email protected]>
Signed-off-by: Future Outlier <[email protected]>
Future-Outlier
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw and
cosmicBboy
as code owners
kumare3
reviewed
Aug 14, 2023
| @@ -1,5 +1,7 @@ | |||
| from typing import TYPE_CHECKING, List, Optional, Union | |||
|
|
|||
| import PIL.Image | |||
There was a problem hiding this comment.
I do not think we need this? We just use PIL.Image.Image so line 17 should be enough right?
There was a problem hiding this comment.
Yes, you are probably right.
kumare3
requested changes
Aug 14, 2023
Just found that you are right, thanks a lot for the review! |
|
Just contact the author of this pull request, I think maybe the bug doesn't exist. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Please replace this text with a description of what this PR accomplishes.
Type
Are all requirements met?
Complete description
You can search "return PIL.Image.open(local_path)" in the code, and you will find that it is not enough to just use "import PIL" in the code.
Tracking Issue
flyteorg/flyte#3813
Follow-up issue
NA
OR
https://github.com/flyteorg/flyte/issues/