Agent Get Pending Message #1834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
August 12, 2023 13:59
For the databricks agent
Signed-off-by: Future Outlier <[email protected]>
Future-Outlier
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw and
cosmicBboy
as code owners
This was referenced Sep 14, 2023
Signed-off-by: Future Outlier <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1834 +/- ##
===========================================
+ Coverage 62.54% 85.80% +23.26%
===========================================
Files 313 313
Lines 23249 23284 +35
Branches 3526 3526
===========================================
+ Hits 14540 19979 +5439
+ Misses 8286 2702 -5584
- Partials 423 603 +180 ☔ View full report in Codecov by Sentry. |
3 tasks
Closed
8 tasks
…nto agent-service-get-message
…nto agent-service-get-message Signed-off-by: Future Outlier <[email protected]>
Signed-off-by: Future Outlier <[email protected]>
added 2 commits
November 5, 2023 20:55
Signed-off-by: Future Outlier <[email protected]>
Signed-off-by: Future Outlier <[email protected]>
added 2 commits
November 6, 2023 20:19
Signed-off-by: Future Outlier <[email protected]>
Signed-off-by: Future Outlier <[email protected]>
pingsutw
reviewed
Nov 6, 2023
Co-authored-by: Kevin Su <[email protected]> Signed-off-by: Future Outlier <[email protected]>
Future-Outlier
force-pushed
the
agent-service-get-message
branch
from
dad3e3d
to
539bad1
Compare
added 2 commits
November 7, 2023 09:56
Signed-off-by: Future Outlier <[email protected]>
…nto agent-service-get-message Signed-off-by: Future Outlier <[email protected]>
…nto agent-service-get-message Signed-off-by: Future Outlier <[email protected]>
Signed-off-by: Future Outlier <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
pingsutw
approved these changes
Nov 21, 2023
ringohoffman
pushed a commit
to ringohoffman/flytekit
that referenced
this pull request
Nov 24, 2023
Signed-off-by: Future Outlier <[email protected]> Signed-off-by: Kevin Su <[email protected]> Co-authored-by: Future Outlier <[email protected]> Co-authored-by: Kevin Su <[email protected]> Co-authored-by: Kevin Su <[email protected]>
RRap0so
pushed a commit
to RRap0so/flytekit
that referenced
this pull request
Dec 15, 2023
Signed-off-by: Future Outlier <[email protected]> Signed-off-by: Kevin Su <[email protected]> Co-authored-by: Future Outlier <[email protected]> Co-authored-by: Kevin Su <[email protected]> Co-authored-by: Kevin Su <[email protected]> Signed-off-by: Rafael Raposo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Relay detailed messages to the Flyte console to keep users informed of "Pending" status.
Type
Are all requirements met?
ScreenShots
The test will pass in
base_agent.pyandplugins/flytekit-spark/tests/test_agent.py::test_databricks_agentComplete description
Two months ago, I introduced the Databricks agent service.
Currently, job statuses progress from "pending" to "running" to "succeeded".
To enhance user experience, @pingsutw, @kumare3, and I propose enriching the "pending" status with additional information for Databricks API and future implementations.
This update will relay detailed messages to the Flyte console to keep users informed.
Follow-up issue
flyteorg/flyte#4115
flyteorg/flyte#4106
flyteorg/flyte#3936