Commits on Sep 12, 2024

1. Propagate custom_info Dict through agent Resource …

    - The agent defines a Resource return type with values:
   
      * outputs
      * message
      * log_links
      * phase
   
      These are all a part of the underlying protobuf contract defined in
      flyteidl.
   
      However, the message field custom_info from the protobuf is not here
   
      google.protobuf.Struct custom_info
   
      https://github.com/flyteorg/flyte/blob/519080b6e4e53fc0e216b5715ad9b5b5270f35c0/flyteidl/protos/flyteidl/admin/agent.proto#L140
   
      This field was added in flyteorg/flyte#4874
      but never made it into the corresponding flytekit PR
      flyteorg#2146
   
    - It's useful for agents to return additional metadata about the job,
      and it looks like custom_info is the intended location
   
    - Make a minor refactor to how the agent responds to requests that
      return Resource by implementing to_flyte_idl / from_flyte_idl
      directly
   
   Signed-off-by: ddl-ebrown <[email protected]>
   Signed-off-by: ddl-rliu <[email protected]>

   

   ddl-ebrown authored and ddl-rliu committed Sep 12, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for 6f3489d
   • Browse repository at this point

   Copy the full SHA

   6f3489d View commit details

   Browse the repository at this point in the history

2. Fix test …

   Signed-off-by: ddl-rliu <[email protected]>

   

   ddl-rliu committed Sep 12, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for 1a6348c
   • Browse repository at this point

   Copy the full SHA

   1a6348c View commit details

   Browse the repository at this point in the history