-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interface for remote execution in Jupyter Notebook #2618
Conversation
OHH WOW this is amazing stuff. I am really excited about this. The only problem I see is if we simply convert this into a script it will fail, but we can solve that problem as a separate PR. |
@Mecoli1219 this is great, how about few more unit tests for translator, tracker and entrypoint. Also if you could test if this thing works with some large scale examples, like maybe when we have some state in jupyter notebook etc. Basically a few more real world tests. Also if ray/spark work? |
8bd5e81
to
093ab35
Compare
flytekit/bin/entrypoint.py
Outdated
:param src: The source file to upload | ||
""" | ||
# return md5_bytes and path | ||
return "", file_access.put_data(src, dest) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if it always returns the ""
, why do we need it here?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2618 +/- ##
===========================================
- Coverage 90.87% 49.94% -40.93%
===========================================
Files 74 196 +122
Lines 3331 19824 +16493
Branches 0 2867 +2867
===========================================
+ Hits 3027 9902 +6875
- Misses 304 9399 +9095
- Partials 0 523 +523 ☔ View full report in Codecov by Sentry. |
3a7b9f0
to
75e317f
Compare
@kumare3 Default options and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
self._serialize_and_register(entity=entity, settings=serialization_settings, version=version) | ||
) | ||
try: | ||
import nest_asyncio |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code is the same as line 869~879; could we add a common function for it?
Signed-off-by: Ketan Umare <[email protected]>
Signed-off-by: Ketan Umare <[email protected]>
Signed-off-by: Ketan Umare <[email protected]>
Signed-off-by: Ketan Umare <[email protected]>
Signed-off-by: Mecoli1219 <[email protected]>
Signed-off-by: Mecoli1219 <[email protected]>
Signed-off-by: Mecoli1219 <[email protected]>
Signed-off-by: Mecoli1219 <[email protected]>
Signed-off-by: Mecoli1219 <[email protected]>
…e init_remote() & update doc Signed-off-by: Mecoli1219 <[email protected]>
…python_check Signed-off-by: Mecoli1219 <[email protected]>
Signed-off-by: Mecoli1219 <[email protected]>
Signed-off-by: Mecoli1219 <[email protected]>
Signed-off-by: Mecoli1219 <[email protected]>
Signed-off-by: Mecoli1219 <[email protected]>
Signed-off-by: Mecoli1219 <[email protected]>
Signed-off-by: Mecoli1219 <[email protected]>
a71dd64
to
9599667
Compare
Signed-off-by: Mecoli1219 <[email protected]>
80b6c8d
to
ee69ca5
Compare
0bd6edc
to
6f51bce
Compare
Signed-off-by: Mecoli1219 <[email protected]>
6f51bce
to
fbf7e24
Compare
Signed-off-by: Mecoli1219 <[email protected]>
Signed-off-by: Mecoli1219 <[email protected]>
Signed-off-by: Mecoli1219 <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Done in #2733. We can open a new PR if we want to revisit the interface. |
Tracking issue or PR
#2579
Why are the changes needed?
Enable this usage:
What changes were proposed in this pull request?
remote()
function for workflow and task.init_remote()
function to store the remote configuration.FlyteFuture
class to store the remote execution data.interactive_mode_enabled
=> check pickle & no dest-dirHow was this patch tested?
All the tests were tested locally.
ipynb
file similar to the one provided in [wip] Jupyter notebooks support - run tasks on remote cluster! #2579 (https://www.loom.com/share/1369e80571e8427fbfc8e2c6ad127d67?sid=658c01ce-da5c-4bff-b50d-57c61107fba6) with the new interface.Dockerfile.dev
.Screenshots
get_deck()
Check all the applicable boxes
Related PRs
#2579
Docs link