Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Upgrade dependencies #122

Merged
merged 9 commits into from
Jul 8, 2022
Merged

Upgrade dependencies #122

merged 9 commits into from
Jul 8, 2022

Conversation

mayitbeegh
Copy link
Contributor

@mayitbeegh mayitbeegh commented Mar 30, 2022

TL;DR

Upgrade dependencies so flytestdlib no longer has a dependency on github.com/dgrijalva/jwt-go which introduces CVE-2020-26160.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

Tracking Issue

Follow-up issue

NA

Signed-off-by: Sean Lin <[email protected]>
@welcome
Copy link

welcome bot commented Mar 30, 2022

Thank you for opening this pull request! 🙌

These tips will help get your PR across the finish line:

  • Most of the repos have a PR template; if not, fill it out to the best of your knowledge.
  • Sign off your commits (Reference: DCO Guide).

@mayitbeegh mayitbeegh changed the title Upgrade dependencies wip: Upgrade dependencies Mar 30, 2022
@codecov
Copy link

codecov bot commented Mar 30, 2022

Codecov Report

Merging #122 (2918e61) into master (1279ea2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #122   +/-   ##
=======================================
  Coverage   68.75%   68.75%           
=======================================
  Files          69       69           
  Lines        3405     3405           
=======================================
  Hits         2341     2341           
  Misses        905      905           
  Partials      159      159           
Flag Coverage Δ
unittests 67.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1279ea2...2918e61. Read the comment docs.

@mayitbeegh mayitbeegh changed the title wip: Upgrade dependencies Upgrade dependencies Mar 30, 2022
@mayitbeegh mayitbeegh marked this pull request as ready for review March 30, 2022 22:48
@katrogan
Copy link
Contributor

do you mind testing this out in plugins, propeller & admin before merging?

@EngHabu
Copy link
Contributor

EngHabu commented Apr 6, 2022

Is this ready for review? @mayitbeegh

@mayitbeegh mayitbeegh changed the title Upgrade dependencies wip: Upgrade dependencies Apr 13, 2022
@mayitbeegh mayitbeegh changed the title wip: Upgrade dependencies Upgrade dependencies Apr 13, 2022
@mayitbeegh mayitbeegh changed the title Upgrade dependencies wip: Upgrade dependencies Apr 13, 2022
@mayitbeegh mayitbeegh changed the title wip: Upgrade dependencies Upgrade dependencies Jun 28, 2022
@mayitbeegh
Copy link
Contributor Author

mayitbeegh commented Jun 28, 2022

PR checked in:
Flytestdlib #122
Flyteidl flyteorg/flyteidl#291
Flyteplugin flyteorg/flyteplugins#258
Flytepropeller flyteorg/flytepropeller#422
Flyteadmin flyteorg/flyteadmin#399
@katrogan @EngHabu

@mayitbeegh mayitbeegh merged commit c9998d3 into master Jul 8, 2022
@welcome
Copy link

welcome bot commented Jul 8, 2022

Congrats on merging your first pull request! 🎉

@mayitbeegh mayitbeegh deleted the upgrade-dependencies branch July 8, 2022 17:54
eapolinario pushed a commit that referenced this pull request Sep 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants