Custom types #180
Merged
Custom types #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| var customHooks = _.flatten(_.map(_.keys(customTypes), function(key) { | ||
| // Modify a names of the hooks to include field name they applied to | ||
| _.each(customTypes[key].hooks, function(whenHooks, when) { |
There was a problem hiding this comment.
Does it expect a structure like this? It kind of doesn't follow semantics of hooks?
{before: {
write: {
fn: function(){}
}
}
}`
There was a problem hiding this comment.
Yes, it does. But not sure what you meant by "It kind of doesn't follow semantics of hooks?". Can you pls extend the statement
There was a problem hiding this comment.
Usage example, just in case: https://bitbucket.org/flyvictor/user-service/pull-requests/853/sup-661-custom-type-usage-example-do-not/diff
There was a problem hiding this comment.
Ok, think i got it. In design doc these hooks were passed through as properties of options, but chaining is probably even better.
This was referenced Feb 1, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.