Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added unified parsing #53

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

nspielbau
Copy link
Contributor

See #51

Signed-off-by: Niklas Spielbauer <[email protected]>
Signed-off-by: Niklas Spielbauer <[email protected]>
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 0% with 22 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (4a12eec) to head (50340c1).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
catmux/window.py 0.00% 12 Missing ⚠️
catmux/split.py 0.00% 6 Missing ⚠️
catmux/session.py 0.00% 2 Missing ⚠️
catmux/utils.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #53       +/-   ##
==========================================
- Coverage   89.24%   0.00%   -89.25%     
==========================================
  Files           6       7        +1     
  Lines         251     255        +4     
==========================================
- Hits          224       0      -224     
- Misses         27     255      +228     
Flag Coverage Δ
unittests 0.00% <0.00%> (-89.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@fmauch fmauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fair. @nspielbau would you mind having a look at my small comments?

catmux/split.py Outdated Show resolved Hide resolved
catmux/utils.py Outdated Show resolved Hide resolved
Signed-off-by: Niklas Spielbauer <[email protected]>
@nspielbau
Copy link
Contributor Author

I also added a check to skip over empty splits, as the session creation failed otherwise. We can drop that if we don't want that

@nspielbau nspielbau marked this pull request as draft February 4, 2025 07:57
@nspielbau
Copy link
Contributor Author

During testing, I realized that the 'tiled' window of the example session was not initialized correctly with this command parsing. I will take a look at that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants