feat(_interfaces): modify prepare_scoring to allow make_scorer function as custom scoring
#68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Juanpablor5
changed the title
prepare_scoring to allow make_scorer function as custom scoring
Juanpablor5
force-pushed
the
maa-jpra-readme_update
branch
from
e3ff27b to
64c3b98
Compare
Juanpablor5
force-pushed
the
maa-jpra-readme_update
branch
from
c322a8d to
af17eb6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Modified
prepare_scoringfunction to allow amake_scorerobject as custom scoring.Description
Currently, the
prepare_scoringfunction for custom scoring cases is expecting a dictionary, not amake_scorerinstance. With this change, the user is allowed to send a dictionary or amake_scorerobject.Added unit tests to check both scenarios.