Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activities list inline edit #389

Merged
merged 30 commits into from
Aug 12, 2024
Merged

Conversation

syoungfntech
Copy link

@syoungfntech syoungfntech commented Mar 29, 2024

https://tipit.avaza.com/project/view/203215#!tab=task-pane&groupby=ProjectSection&view=vertical&task=3490056&stafilter=NotComplete&fileview=grid

Allow the ability to inline edit list (rows)

Checkbox selects (option for select all), enable inline edit (input texts) upon click of "Edit Selected" button

Editable columns:

  • Activity type
  • Title
  • Speakers
  • Activity Category
  • Selection Plan
  • Streaming URL
  • Meeting URL
  • Etherpad Link

@@ -119,6 +68,7 @@ const eventListReducer = (state = DEFAULT_STATE, action) => {
let {term} = payload;
return {...state, term};
}
case UPDATED_REMOTE_EVENTS:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this action is a no op
should be removed

@smarcet
Copy link

smarcet commented Apr 1, 2024

@syoungfntech taking a quick look seems that
src/components/tables/editable-table/EventsEditableTable.js and src/components/tables/editable-table/EventsEditableTableRow.js arent generic enough on their implementation to be applied to other grids on show admin,
they need some refactor and get externalized all embedded logic related to activities using Inversion of Control Principle

Signed-off-by: Tomás Castillo <tcastilloboireau@gmail.com>
@tomrndom tomrndom force-pushed the features/events-list-inline-edit-2 branch from d2dde18 to 9bfc27f Compare July 9, 2024 21:04
tomrndom and others added 12 commits July 10, 2024 11:49
Signed-off-by: Tomás Castillo <tomrndom@users.noreply.github.com>
Signed-off-by: Tomás Castillo <tomrndom@users.noreply.github.com>
Signed-off-by: Tomás Castillo <tcastilloboireau@gmail.com>
Signed-off-by: Tomás Castillo <tcastilloboireau@gmail.com>
Signed-off-by: Tomás Castillo <tomrndom@users.noreply.github.com>
Signed-off-by: Tomás Castillo <tomrndom@users.noreply.github.com>
Signed-off-by: Tomás Castillo <tcastilloboireau@gmail.com>
Signed-off-by: Tomás Castillo <tcastilloboireau@gmail.com>
Signed-off-by: Tomás Castillo <tcastilloboireau@gmail.com>
… payload for bulk events

Signed-off-by: Tomás Castillo <tcastilloboireau@gmail.com>
Copy link

@smarcet smarcet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tomrndom please review comments

tomrndom and others added 2 commits August 8, 2024 11:08
Signed-off-by: Tomás Castillo <tcastilloboireau@gmail.com>
Signed-off-by: Tomás Castillo <tomrndom@users.noreply.github.com>
Signed-off-by: Tomás Castillo <tcastilloboireau@gmail.com>
Signed-off-by: Tomás Castillo <tcastilloboireau@gmail.com>
Signed-off-by: Tomás Castillo <tcastilloboireau@gmail.com>
Signed-off-by: Tomás Castillo <tcastilloboireau@gmail.com>
Signed-off-by: Tomás Castillo <tcastilloboireau@gmail.com>
Copy link

@smarcet smarcet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smarcet smarcet merged commit a81f090 into master Aug 12, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants