fix: replace ticket types ddl with uicore component #540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarcet
reviewed
Nov 18, 2024
| placeholder={T.translate( | ||
| "ticket_list.placeholders.ticket_types" | ||
| )} | ||
| name="ticketTypesFilter" | ||
| value={ticketFilters.ticketTypesFilter} | ||
| onChange={(val) => | ||
| this.handleFilterChange("ticketTypesFilter", val) | ||
| onChange={(ev) => |
There was a problem hiding this comment.
lets create a helper method to translate the value retrieved by TicketTypesInput to the ones expected by the actions ( rollback action changes )
also review ticket action https://github.com/fntechgit/summit-admin/pull/540/files#diff-e34888831de52961fbe9061efcda081680b4ff79c8211c5b93069c37b2879c2eR199
smarcet
reviewed
Nov 18, 2024
smarcet
requested changes
Nov 18, 2024
There was a problem hiding this comment.
@tomrndom review comments
also review use
lets use the uicore version of the method as stated on the tix description or lets create our own vesion
and on case like
https://github.com/fntechgit/summit-admin/blob/master/src/components/forms/tax-type-form.js#L105
that use a SimpleLinkList
use query action queryTicketTypes from uicore
tomrndom
force-pushed
the
hotfix/ticket-types-ddl
branch
from
c34ca28 to
f3b429b
Compare
Signed-off-by: Tomás Castillo <[email protected]>
Signed-off-by: Tomás Castillo <[email protected]>
Signed-off-by: Tomás Castillo <[email protected]>
Signed-off-by: Tomás Castillo <[email protected]>
Signed-off-by: Tomás Castillo <[email protected]>
Signed-off-by: Tomás Castillo <[email protected]>
Signed-off-by: Tomás Castillo <[email protected]>
Signed-off-by: Tomás Castillo <[email protected]>
Signed-off-by: Tomás Castillo <[email protected]>
tomrndom
force-pushed
the
hotfix/ticket-types-ddl
branch
from
52d9170 to
7ae3823
Compare
Signed-off-by: Tomás Castillo <[email protected]>
Signed-off-by: Tomás Castillo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: https://tipit.avaza.com/task#!sortby=DateUpdatedDesc&task=3669838
Signed-off-by: Tomás Castillo [email protected]