Add config argument to specify valid markdown flavors #1424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/github.com/MilesMcBain/foam but make it general based on a new config in settings.json, "foam.supportedLanguages". That should allow for rmarkdown files as well.
riccardoferretti
approved these changes
Feb 13, 2025
|
Can you please fix the typo reporting? (see |
|
Sure! I used yarn to package the extension and was getting a warning about two lock files in a single project. I just renamed the npm one to disable it temporarily. Is it alright to remove the npm lock file entirely? |
n8layman
commented
Feb 14, 2025
|
Is there anything else needed? |
|
@allcontributors add @n8layman for code |
|
I've put up a pull request to add @n8layman! 🎉 |
|
all good, thanks @n8layman ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to address Problem 2 raised by @MilesMcBain in #1399 by implementing a configuration option, e.g.,
"foam.supportedLanguages": ["markdown", "quarto", "rmarkdown"],, to specify valid markdown-like flavors as suggested in #924. This is my first PR to an open-source project, so please review carefully and let me know if there are any additional steps, tests, or changes needed!