melos: starknet-devnet and starkli are now part of asdf plugins community

[ptisserand]

starknet-devnet and starkli are now available in asdf-vm plugins community.

Summary by CodeRabbit

• Chores
  • Simplified the installation process for starknet-devnet and starkli plugins by removing specific URLs.
  • Updated comments in the contracts:invoke script to clarify expected transaction behavior.

[docs-page]

To view this pull requests documentation preview, visit the following URL:

docs.page/focustree/starknet.dart~405

Documentation is deployed and generated using docs.page.

[coderabbitai]

Walkthrough

The melos.yaml file has been modified to improve the setup and management of development environments and scripts. Key changes include updates to the starknet:setup script for easier plugin addition by removing specific URLs from commands and simplifying the run commands for plugins. Additionally, the contracts:invoke script now includes a comment clarifying the expected transaction hash for a specific invoke operation. Overall, these changes enhance the setup process and documentation without altering the logic or functionality of the scripts.

Changes

File	Change Summary
melos.yaml	Updated starknet:setup script to simplify plugin addition by removing URLs; modified contracts:invoke script to add a comment about expected transaction hash.

Poem

In the meadow where scripts do play,
Plugins dance in a simpler way.
With a hop and a skip, they’re added with glee,
Clarity blooms like a bright spring tree.
Hooray for the changes, let’s cheer and prance,
In the world of code, we take a joyful chance! 🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

melos.yaml (1)

Line range hint 97-97: Helpful addition of expected transaction hash!

The inclusion of the expected transaction hash in the comment is a valuable addition. It provides important context for developers and can be useful for debugging or verification purposes.

To maintain consistency with the comment style used elsewhere in the file, consider using a # symbol at the start of each line for multi-line comments. Here's a suggested minor improvement:

# should create tx hash 0x029583643cd8932f1955bf28bfebf4c907b13df1e5c2d202b133cfbf783697a2

This change would align the comment style with other comments in the file, enhancing overall readability.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between a3ab174 and 246779b.

📒 Files selected for processing (1)

• melos.yaml (1 hunks)

🧰 Additional context used

🔇 Additional comments (2)

melos.yaml (2)

33-34: Excellent simplification of plugin installation!

The removal of specific URLs from the asdf plugin add commands for starknet-devnet and starkli is a great improvement. This change:

1. Aligns with the PR objectives, reflecting the integration of these plugins into the asdf-vm plugins community.
2. Simplifies the setup process, making it more straightforward for developers.
3. Improves maintainability by reducing the need to update URLs in the future.
4. Enhances the script's adaptability to potential changes in the plugin ecosystem.

These modifications streamline the development environment setup without altering the core functionality.

Also applies to: 41-42

---

Line range hint 1-150: Overall, excellent improvements to the melos.yaml file!

The changes made to this file align perfectly with the PR objectives and bring several benefits:

1. Simplification of the plugin installation process in the starknet:setup script.
2. Enhanced documentation in the contracts:invoke script.
3. Improved maintainability and adaptability of the setup process.

These modifications streamline the development workflow without introducing any risks or altering core functionalities. Great job on these updates!