feat: change default value of cffu.uncaught.exception.report to `fu…

…ll`; fail LOUDLY 💣
foldright · Nov 27, 2024 · 2d8da6c · 2d8da6c
1 parent cd17f85
commit 2d8da6c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/cffu-core/src/main/java/io/foldright/cffu/ExceptionReporter.java b/cffu-core/src/main/java/io/foldright/cffu/ExceptionReporter.java
@@ -25,7 +25,7 @@ static <T> T reportUncaughtException(String where, Throwable ex) {
         final String shortReport = "short";
         final String noneReport = "none";
 
-        final String report = System.getProperty("cffu.uncaught.exception.report", shortReport);
+        final String report = System.getProperty("cffu.uncaught.exception.report", fullReport);
         final String msgHead = "Uncaught exception occurred at ";
         if (noneReport.equalsIgnoreCase(report)) {
             // pass silently when explicitly silenced.

diff --git a/scripts/integration_test b/scripts/integration_test
@@ -65,16 +65,18 @@ mvu::mvn_cmd clean install
 readonly MVN_OPTS_FOR_JAVA8=(
   -Dkotlin.version=1.6.0 -Dguava.version=29.0-jre
   -P!default-logging-dependencies -P!default-arch-unit-test
+  -Dcffu.uncaught.exception.report=short
 )
 # shellcheck disable=SC2034
 readonly MVN_OPTS_FOR_JAVA11=(
   -Dkotlin.version=1.7.0
   -DswitchToLog4j2LoggingDependencies -Pswitch-slf4j-to-v1
+  -Dcffu.uncaught.exception.report=short
 )
 # shellcheck disable=SC2034
 readonly MVN_OPTS_FOR_JAVA17=(
   -Dkotlin.version=1.8.0
-  -DswitchToLog4j2LoggingDependencies -Dcffu.uncaught.exception.report=full
+  -DswitchToLog4j2LoggingDependencies -Dcffu.uncaught.exception.report=short
 )
 # shellcheck disable=SC2034
 readonly MVN_OPTS_FOR_JAVA23=(
@@ -94,8 +96,8 @@ for jdk_version in "${JDK_VERSIONS[@]}"; do
 
   jvu::switch_to_jdk "$jdk_version"
 
-  # skip kotlin module test for low java version(19-)
-  # need recompile and test later(more info see the comments)
+  # skip kotlin module test for low java version(18-)
+  # need recompile and test later(more info see its comments)
   pl=()
   if ((jdk_version < default_build_jdk_version && jdk_version < 19)); then
     pl=(-pl 'cffu-core,cffu-ttl-executor-wrapper')