MODLD-601: LCCN deduplication #1634
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PBobylev
approved these changes
Nov 28, 2024
...d-data/src/main/resources/citation/mod-linked-data/features/util/validation-resource.feature
Outdated
Show resolved
Hide resolved
| * call putResource { id: '#(instanceId)' , resourceRequest: '#(instanceRequest)' } | ||
|
|
||
| # Step 4: Create new instance with existing LCCN, verify bad request | ||
| * eval workRequest.resource['http://bibfra.me/vocab/lite/Work']['http://bibfra.me/vocab/marc/title'][0]['http://bibfra.me/vocab/marc/Title']['http://bibfra.me/vocab/marc/mainTitle'] = ['new_title'] |
There was a problem hiding this comment.
maybe better to add separate samples instead of such lines of code? (same for instance)
MODLD-601: LCCN deduplication test
AndreiBordak
force-pushed
the
MODLD-601
branch
from
d6752b5 to
f198ad9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Cover a scenario with LCCN deduplication.
Approach
API based approach. Enable validation setting -> Check deduplication works as expected -> Disable and check again
TODOS and Open Questions
Learning