FAT-17756: set loadReferenceData: true for linked-data tests #1651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkjacob
requested review from
askhat-abishev,
AndreiBordak and
PBobylev
and removed request for
askhat-abishev and
AndreiBordak
pkjacob
force-pushed
the
pjacob/FAT-17756
branch
from
07c2be3 to
3111bb8
Compare
pkjacob
force-pushed
the
pjacob/FAT-17756
branch
from
3111bb8 to
77f632c
Compare
pkjacob
commented
Dec 23, 2024
| @@ -12,6 +12,7 @@ function fn() { | |||
| var testTenant = karate.properties['testTenant']; | |||
|
|
|||
| var config = { | |||
| tenantParams: {loadReferenceData: true}, | |||
There was a problem hiding this comment.
Setting loadReferenceData: true will initialize all the reference data for the tenant when the tenant is initialized.
So, we do not have to load the authority files and instance types programmatically, as we did earlier.
askhat-abishev
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
set loadReferenceData: true for linked-data tests
Some tests were failing because reference data like mod_of_issuance were not present in the DB. To fix this, I am loading all the ref data required by different modules by setting {loadReferenceData: true} in karate-config.js file. As a result, we can now remove the reference data that we were programmatically creating earlier