CIRC-2148: Fixed PR comments

folio-org · Sep 23, 2024 · 5971432 · 5971432
1 parent f60e5af
commit 5971432
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 9 deletions.
diff --git a/src/main/java/org/folio/circulation/resources/RequestFromRepresentationService.java b/src/main/java/org/folio/circulation/resources/RequestFromRepresentationService.java
@@ -582,8 +582,6 @@ private Request removeRelatedRecordInformation(Request request) {
     if (printDetails != null && printDetails.containsKey("lastPrintRequester")) {
       printDetails.remove("lastPrintRequester");
     }
-
-
     return request;
   }
 

diff --git a/src/test/java/api/requests/RequestsAPIRetrievalTests.java b/src/test/java/api/requests/RequestsAPIRetrievalTests.java
@@ -875,9 +875,7 @@ void printDetailsTest() {
     UserResource printDetailsRequester = usersFixture.charlotte();
     UUID printDetailsRequesterId = printDetailsRequester.getId();
     final IndividualResource smallAngryPlanet = itemsFixture.basedUponSmallAngryPlanet();
-
     final IndividualResource workAddressType = addressTypesFixture.work();
-
     final IndividualResource charlotte = usersFixture.charlotte(
       builder -> builder.withAddress(
         new Address(workAddressType.getId(),
@@ -888,15 +886,14 @@ void printDetailsTest() {
           "Fake postal code",
           "Fake country code")));
 
-
     requestsFixture.place(new RequestBuilder()
       .page()
       .forItem(smallAngryPlanet)
       .deliverToAddress(workAddressType.getId())
       .by(charlotte)
-      .withPrintDetails(new RequestBuilder.PrintDetails(49, printDetailsRequesterId.toString(), true, "2024-09-16T11:58:22" +
-        ".295+00:00")));
-
+      .withPrintDetails(new RequestBuilder
+        .PrintDetails(49, printDetailsRequesterId.toString(),
+        true, "2024-09-16T11:58:22.295+00:00")));
 
     final MultipleJsonRecords requests = requestsFixture.getRequests(
       queryFromTemplate("printDetails.isPrinted==%s", "true"),

diff --git a/src/test/java/api/support/fakes/FakeStorageModule.java b/src/test/java/api/support/fakes/FakeStorageModule.java
@@ -390,7 +390,9 @@ private void getMany(RoutingContext routingContext) {
 
     result.put(collectionPropertyName, new JsonArray(pagedItems));
     result.put("totalRecords", filteredItems.size());
-
+    if(collectionPropertyName.equalsIgnoreCase("requests")) {
+      System.out.println();
+    }
     log.debug("Found {} resources: {}", recordTypeName, result.encodePrettily());
 
     HttpServerResponse response = routingContext.response();
-Original file line number
+Diff line change
@@ Expand Up @@
         if (printDetails != null && printDetails.containsKey("lastPrintRequester")) {
           printDetails.remove("lastPrintRequester");
         }
         return request;
       }
@@ Expand Down @@