CIRC-1932 include review comments

folio-org · Oct 31, 2023 · 6067809 · 6067809
1 parent 99f8016
commit 6067809
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 10 deletions.
diff --git a/ramls/pick-slips-response.json → ramls/staff-slips-response.json b/ramls/pick-slips-response.json → ramls/staff-slips-response.json
diff --git a/ramls/pick-slips.raml → ramls/staff-slips.raml b/ramls/pick-slips.raml → ramls/staff-slips.raml
@@ -1,15 +1,15 @@
 #%RAML 1.0
-title: Slips
+title: Stuff Slips
 version: v0.3
 protocols: [ HTTP, HTTPS ]
 baseUri: http://localhost:9130
 
 documentation:
-  - title: API for fetching current pick and search slips
-    content: <b>API for pick and search slips generation</b>
+  - title: API for fetching current staff slips
+    content: <b>API for staff slips generation</b>
 
 types:
-  pick-slips: !include pick-slips-response.json
+  stuff-slips: !include staff-slips-response.json
 
 traits:
   language: !include raml-util/traits/language.raml
@@ -22,11 +22,11 @@ resourceTypes:
       /{servicePointId}:
         type:
           collection-get:
-            exampleCollection: !include examples/pick-slips-response.json
-            schemaCollection: pick-slips
+            exampleCollection: !include examples/staff-slips-response.json
+            schemaCollection: stuff-slips
     /search-slips:
       /{servicePointId}:
         type:
           collection-get:
-            exampleCollection: !include examples/pick-slips-response.json
-            schemaCollection: pick-slips
+            exampleCollection: !include examples/staff-slips-response.json
+            schemaCollection: stuff-slips
diff --git a/src/test/java/api/requests/SearchSlipsTests.java b/src/test/java/api/requests/SearchSlipsTests.java
@@ -14,7 +14,7 @@
 import io.vertx.core.json.JsonObject;
 
 class SearchSlipsTests extends APITests {
-  private static final String TOTAL_RECORDS = "totalRecords";
+  private static final String TOTAL_RECORDS_KEY = "totalRecords";
   private static final String SEARCH_SLIPS_KEY = "searchSlips";
 
   @Test
@@ -27,6 +27,6 @@ void responseShouldHaveEmptyListOfSearchSlipsRecords() {
   private void assertResponseHasItems(Response response, int itemsCount) {
     JsonObject responseJson = response.getJson();
     assertThat(responseJson.getJsonArray(SEARCH_SLIPS_KEY).size(), is(itemsCount));
-    assertThat(responseJson.getInteger(TOTAL_RECORDS), is(itemsCount));
+    assertThat(responseJson.getInteger(TOTAL_RECORDS_KEY), is(itemsCount));
   }
 }