CIRC-2050 incorporating review comments

folio-org · Apr 2, 2024 · d22d472 · d22d472
1 parent 4ede011
commit d22d472
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/src/main/java/org/folio/circulation/domain/AllowedServicePointsRequest.java b/src/main/java/org/folio/circulation/domain/AllowedServicePointsRequest.java
@@ -25,6 +25,7 @@ public class AllowedServicePointsRequest {
   public boolean isForTitleLevelRequest() {
     return instanceId != null;
   }
+
   public boolean isForItemLevelRequest() {
     return itemId != null;
   }

diff --git a/...n/java/org/folio/circulation/infrastructure/storage/requests/RequestPolicyRepository.java b/...n/java/org/folio/circulation/infrastructure/storage/requests/RequestPolicyRepository.java
@@ -97,6 +97,8 @@ public CompletableFuture<Result<Map<RequestPolicy, Set<Item>>>> lookupRequestPol
   }
 
   public CompletableFuture<Result<RequestPolicy>> lookupRequestPolicy(User user) {
+    // Circulation rules need to be executed with the patron group parameter only.
+    // All the item-related parameters should be random UUIDs.
     return lookupRequestPolicyId(UUID.randomUUID().toString(), user.getPatronGroupId(),
       UUID.randomUUID().toString(), UUID.randomUUID().toString())
       .thenCompose(r -> r.after(this::lookupRequestPolicy))