CIRC-1482 create test for overdue recall fine calculation when recall… #1074
Conversation
… request creation
viktor-draban
requested review from
sherzodn,
alexanderkurash,
roman-barannyk,
OleksandrVidinieiev,
bisecomsergiy,
Mykyta-Varenyk and
yusuf-murodov-gamerpay
| .withName("1 minute policy") | ||
| .withDescription("Can circulate item") | ||
| .rolling(Period.minutes(1)) | ||
| .withGracePeriod(Period.zeroDurationPeriod()) |
There was a problem hiding this comment.
Do we really need this line? Don't we hae zero grace period by default?
| .withId(UUID.randomUUID()) | ||
| .withName("One per minute overdue fine and overdue recall fine policy") | ||
| .withCountClosed(true) | ||
| .withGracePeriodRecall(false) |
There was a problem hiding this comment.
Do we really need this line? Don't we have zero grace period by default?
| .withOwner("fee-fine-owner") | ||
| .withServicePointOwner(Collections.singletonList(new JsonObject() | ||
| .put("value", homeLocation.getJson().getString("primaryServicePoint")) | ||
| .put("label", "label")))); |
| .unlimitedRenewals() | ||
| .renewFromSystemDate()).getId(), |
There was a problem hiding this comment.
Do we really need this, keeping in mind that we don't use renew in this test?
|
|
||
| ZonedDateTime checkOutDate = ZonedDateTime.of(2020, 1, 18, 18, 0, 0, 0, UTC); | ||
| ZonedDateTime requestDate = ZonedDateTime.of(2020, 1, 19, 18, 0, 0, 0, UTC); | ||
| ZonedDateTime checkInDate = ZonedDateTime.of(2020, 1, 22, 15, 30, 0, 0, UTC); |
There was a problem hiding this comment.
How about making the checkin date in minutes after the request date, so that we can see that the amount of overdue recall fees is really different?
|
Kudos, SonarCloud Quality Gate passed!
|
9 similar comments
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kudos, SonarCloud Quality Gate passed!
|
|
1 similar comment
|
|
ticket
create test for overdue recall fine calculation when recall request creation