-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split item status enum CIRC-1416 #1124
Draft
marcjohnson-kint
wants to merge
27
commits into
master
Choose a base branch
from
CIRC-1416-split-item-status-enum
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcjohnson-kint
requested review from
K-Felk,
a user,
alexanderkurash,
roman-barannyk and
Mykyta-Varenyk
May 10, 2022 11:28
marcjohnson-kint
changed the title
Circ 1416 split item status enum
Split item status enum CIRC-1416
May 16, 2022
marcjohnson-kint
force-pushed
the
CIRC-1416-split-item-status-enum
branch
from
May 16, 2022 10:20
883caaa
to
5773af1
Compare
marcjohnson-kint
force-pushed
the
CIRC-1416-split-item-status-enum
branch
from
May 16, 2022 10:28
5773af1
to
78d81b9
Compare
marcjohnson-kint
force-pushed
the
CIRC-1416-split-item-status-enum
branch
from
June 22, 2022 09:26
78d81b9
to
dd22a74
Compare
Kudos, SonarCloud Quality Gate passed! |
marcjohnson-kint
force-pushed
the
CIRC-1416-split-item-status-enum
branch
3 times, most recently
from
July 28, 2022 09:32
0a8566a
to
ec7a307
Compare
marcjohnson-kint
removed request for
K-Felk,
a user,
alexanderkurash,
roman-barannyk and
Mykyta-Varenyk
July 28, 2022 09:58
marcjohnson-kint
force-pushed
the
CIRC-1416-split-item-status-enum
branch
2 times, most recently
from
July 28, 2022 18:35
579bef4
to
162ae6c
Compare
First step in fixing the mistake of having an enumeration have mutable state
marcjohnson-kint
force-pushed
the
CIRC-1416-split-item-status-enum
branch
from
August 15, 2022 17:43
162ae6c
to
b870971
Compare
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
In order to make it easier to change the way circulation interacts with inventory records, the representation in the domain could be separated more from the underlying representation of the records in inventory storage.
One of the last remaining usages of the JSON representation is the item status. This requires more dedicated changes due to how the current enumeration has state that it should not have (as enumeration instances as shared).
Approach
TODOS and Open Questions
Learning