CIRC-2050 Add useStubItem parameter to allowed-service-points endpoint #1447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roman-barannyk
requested review from
alexanderkurash,
MagzhanArtykov and
OleksandrVidinieiev
roman-barannyk
force-pushed
the
CIRC-2050
branch
from
3ca5c52 to
43819e4
Compare
src/main/java/org/folio/circulation/domain/AllowedServicePointsRequest.java
Outdated
Show resolved
Hide resolved
...main/java/org/folio/circulation/infrastructure/storage/requests/RequestPolicyRepository.java
Show resolved
Hide resolved
src/main/java/org/folio/circulation/resources/AllowedServicePointsResource.java
Outdated
Show resolved
Hide resolved
roman-barannyk
force-pushed
the
CIRC-2050
branch
from
b9e7952 to
533b373
Compare
OleksandrVidinieiev
approved these changes
Apr 2, 2024
|
alexanderkurash
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Add a non-required boolean parameter useStubItem to an endpoint GET /circulation/requests/allowed-service-points. Default value is false.
When set to true, it should change the behavior:
Instead of running circulation rules for each item of the title, circulation rules need to be executed with the patron group parameter only. All of the item-related parameters (materialTypeId, loanTypeId, locationId) should be random UUIDs.
Resolves: CIRC-2050