CIRC-2051 Add ecsRequestRouting parameter to allowed-service-points #1451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roman-barannyk
requested review from
alexanderkurash,
OleksandrVidinieiev and
MagzhanArtykov
| @@ -99,6 +100,13 @@ private static Result<AllowedServicePointsRequest> buildRequest(RoutingContext r | |||
| useStubItem); | |||
| errors.add(String.format("useStubItem is not a valid boolean: %s.", useStubItem)); | |||
| } | |||
| if (ecsRequestRouting != null && !"true".equals(ecsRequestRouting) | |||
There was a problem hiding this comment.
Since we are validating boolean string twice now, do you think this check deserves a separate method? Something like isIvalidBooleanString(String boolean)
Comment on lines
149
to
150
| ? "ecsRequestRouting" | ||
| : "pickupLocation"; |
There was a problem hiding this comment.
So we are now searching either by ecsRequestRouting or pickupLocation. Do we not care about the value of pickupLocation when fetching ECS routing service points?
roman-barannyk
force-pushed
the
CIRC-2051
branch
from
9b43fb0 to
b67fbb5
Compare
|
alexanderkurash
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Add a non-required boolean parameter ecsRequestRouting to an endpoint GET /circulation/requests/allowed-service-points. Default value is false.
When set to true, it should change the behavior:
Instead of returning service points with pickupLocation=true we need to only return service points with ecsRequestRouting=true
Resolves: CIRC-2051