[CIRC-2116] Allowed SP endpoint should support patronGroupId parameter #1483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#1455) * CIRC-2051 add ecsRequestRouting to allowed-service-points * CIRC-2051 refactoring * CIRC-2051 move common validation to separate method * CIRC-2051 fix code smells * CIRC-2051 fix code smell * CIRC-2051 tests refactoring * CIRC-2051 rename test
…ature # Conflicts: # descriptors/ModuleDescriptor-template.json # ramls/circulation.raml # src/main/java/org/folio/circulation/domain/AllowedServicePointsRequest.java # src/main/java/org/folio/circulation/resources/AllowedServicePointsResource.java # src/test/java/api/requests/AllowedServicePointsAPITests.java
* CIRC-2081 Fetch TLR settings from mod-settings * CIRC-2081 Fetch TLR settings from mod-settings * CIRC-2081 Refactoring * CIRC-2081 Add permissions * CIRC-2081 Remove redundant changes, fixture refactoring * CIRC-2081 Revert redundant change * CIRC-2081 Merge SettingsBuilder constructors * CIRC-2081 Add global permissions * CIRC-2081 Remove unused methods
CIRC-2072 Create a facade for instance search
* CIRC-2101 Fetch items across tenants * CIRC-2101 Fetch items across tenants * CIRC-2101 Remove @Setter from static field * CIRC-2101 Fix formatting * CIRC-2101 Fetch items across tenants * CIRC-2101 Remove @Setter from static field * CIRC-2101 Fix formatting * CIRC-2101 Add missing permission set * CIRC-2101 Reuse item repository for items in same tenant
# Conflicts: # descriptors/ModuleDescriptor-template.json # src/main/java/org/folio/circulation/support/Clients.java # src/test/java/api/support/http/InterfaceUrls.java # src/test/java/api/support/http/ResourceClient.java
…needed (#1478) * CIRC-2109 Initial implementation * CIRC-2109 Apply suggestions from code review Co-authored-by: Roman Barannyk <[email protected]> * CIRC-2109 Support for fake routing service points * CIRC-2109 Remove unneeded method * CIRC-2109 Add Override annotation * CIRC-2109 Apply suggestions from code review Co-authored-by: Roman Barannyk <[email protected]> * CIRC-2019 Update src/test/java/api/support/fakes/FakeCQLToJSONInterpreter.java Co-authored-by: Roman Barannyk <[email protected]> * CIRC-2109 Fix github suggestion commit * CIRC-2109 Code review 1 * CIRC-2109 Revert FakeStorageModuleBuilder --------- Co-authored-by: Roman Barannyk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Covers: CIRC-2116
Purpose
Allowed SP endpoint should support patronGroupId parameter