CIRC-2117 Return empty result when search doesn't find anything #1485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maksat-Galymzhan
force-pushed
the
CIRC-2117
branch
from
ed6e028 to
82758f6
Compare
Maksat-Galymzhan
requested review from
MagzhanArtykov,
alexanderkurash,
roman-barannyk and
OleksandrVidinieiev
Comment on lines
83
to
84
| IndividualResource instance = instancesFixture.basedUponDunkirk(); | ||
| UUID instanceId = instance.getId(); |
There was a problem hiding this comment.
You mean like this?
UUID instanceId = instancesFixture.basedUponDunkirk().getId();
Since we do not call instance object, we could do like this
There was a problem hiding this comment.
yes, you use this variable only once
There was a problem hiding this comment.
updated, thanks!
| Response response = get(String.format("query=(id==%s)", instanceId), 200); | ||
| JsonObject responseJson = response.getJson(); | ||
|
|
||
| Assertions.assertTrue(responseJson.isEmpty()); |
There was a problem hiding this comment.
I would suggest using the same import for assertions as seen throughout this test
There was a problem hiding this comment.
Thanks for noticing it, fix it
Maksat-Galymzhan
force-pushed
the
CIRC-2117
branch
from
e16908b to
d96c998
Compare
roman-barannyk
approved these changes
Jul 17, 2024
| clearTempTenantId(); | ||
|
|
||
| // make sure neither item exists in current tenant | ||
| assertThat(itemsFixture.getById(collegeItem.getId()).getResponse().getStatusCode(), is(404)); |
There was a problem hiding this comment.
Suggested change
| assertThat(itemsFixture.getById(collegeItem.getId()).getResponse().getStatusCode(), is(404)); | |
| assertThat(itemsFixture.getById(collegeItem.getId()).getResponse().getStatusCode(), is(HttpStatus.NOT_FOUND)); |
| assertThat(itemsFixture.getById(universityItem.getId()).getResponse().getStatusCode(), is(404)); | ||
|
|
||
| ResourceClient.forSearchClient().replace(instanceId, new JsonObject()); | ||
| Response response = get(String.format("query=(id==%s)", instanceId), 200); |
There was a problem hiding this comment.
Suggested change
| Response response = get(String.format("query=(id==%s)", instanceId), 200); | |
| Response response = get(String.format("query=(id==%s)", instanceId), HttpStatus.HTTP_OK); |
Comment on lines
102
to
103
| assertThat(itemsFixture.getById(collegeItem.getId()).getResponse().getStatusCode(), is(HttpStatus.HTTP_NOT_FOUND.toInt())); | ||
| assertThat(itemsFixture.getById(universityItem.getId()).getResponse().getStatusCode(), is(HttpStatus.HTTP_NOT_FOUND.toInt())); |
There was a problem hiding this comment.
Suggested change
| assertThat(itemsFixture.getById(collegeItem.getId()).getResponse().getStatusCode(), is(HttpStatus.HTTP_NOT_FOUND.toInt())); | |
| assertThat(itemsFixture.getById(universityItem.getId()).getResponse().getStatusCode(), is(HttpStatus.HTTP_NOT_FOUND.toInt())); | |
| assertThat(itemsFixture.getById(collegeItem.getId()).getResponse().getStatusCode(), | |
| is(HTTP_NOT_FOUND.toInt())); | |
| assertThat(itemsFixture.getById(universityItem.getId()).getResponse().getStatusCode(), | |
| is(HTTP_NOT_FOUND.toInt())); |
| assertThat(itemsFixture.getById(universityItem.getId()).getResponse().getStatusCode(), is(HttpStatus.HTTP_NOT_FOUND.toInt())); | ||
|
|
||
| ResourceClient.forSearchClient().replace(instanceId, new JsonObject()); | ||
| Response response = get(String.format("query=(id==%s)", instanceId), HttpStatus.HTTP_OK.toInt()); |
There was a problem hiding this comment.
Suggested change
| Response response = get(String.format("query=(id==%s)", instanceId), HttpStatus.HTTP_OK.toInt()); | |
| Response response = get(String.format("query=(id==%s)", instanceId), HTTP_OK.toInt()); |
Maksat-Galymzhan
force-pushed
the
CIRC-2117
branch
from
576bbb7 to
422ba2c
Compare
|
OleksandrVidinieiev
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Return empty result when search doesn't find anything
Learning
CIRC-2117