CIRC-2141 Allow specifying item location when creating title-level re… #1491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanisSaldabols
force-pushed
the
CIRC-2141
branch
from
8522965 to
e70f55b
Compare
JanisSaldabols
requested review from
nielserik and
alexanderkurash
and removed request for
nielserik
|
@alexanderkurash Can I ask you or someone else from Vega to review this PR? This feature has been cleared Steph and Thomas. Thanks! |
src/main/java/org/folio/circulation/services/ItemForTlrService.java
Outdated
Show resolved
Hide resolved
src/main/java/org/folio/circulation/services/ItemForTlrService.java
Outdated
Show resolved
Hide resolved
src/main/java/org/folio/circulation/services/ItemForTlrService.java
Outdated
Show resolved
Hide resolved
JanisSaldabols
force-pushed
the
CIRC-2141
branch
from
f27bfaa to
6ca8d92
Compare
OleksandrVidinieiev
approved these changes
Oct 2, 2024
|
|
||
| public boolean isAtLocation(String locationCode) { | ||
| if (locationCode == null || locationCode.isEmpty()) { | ||
| return true; |
There was a problem hiding this comment.
Why is it true when location is empty? This does not make much sense.
JanisSaldabols
force-pushed
the
CIRC-2141
branch
from
6ca8d92 to
07d0d4d
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CIRC-2141 Allow specifying item location when creating title-level requests
Purpose
Currently, it’s possible to specify the service point ID when creating the request and select the item with the “nearest” location. However, when the “nearest” location search does not result in a match, the system will create the request for the first item available. The additional filter will allow it to succeed only if the requested item is in the specified location.
This is useful when the request is sent from an ILL system to a FOLIO system that serves multiple institutions and where those ILL requests should be considered independently for each institution.
Approach
Add an optional parameter that allows the client to specify the item’s location code when creating a title-level request. The requested location code should allow to match the item location on any level (institution, campus, library, location).