CIRC-2148: Reverted CIRC-2100 PR and Rework for PrintEventDetail Pagination, searching and sorting #1492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for update request, reverted some permissions, added new printDetails fields in request.json
kapil-epam
requested review from
alexanderkurash,
gurleenkaurbp and
SreejaMangarapu
Comment on lines
890
to
891
|
|
||
|
|
There was a problem hiding this comment.
Do we need two blank lines here?
Comment on lines
899
to
900
|
|
||
|
|
There was a problem hiding this comment.
Do we need two blank lines here?
Comment on lines
585
to
586
|
|
||
|
|
There was a problem hiding this comment.
Do we need two blank lines here?
| .forItem(smallAngryPlanet) | ||
| .deliverToAddress(workAddressType.getId()) | ||
| .by(charlotte) | ||
| .withPrintDetails(new RequestBuilder.PrintDetails(49, printDetailsRequesterId.toString(), true, "2024-09-16T11:58:22" + |
There was a problem hiding this comment.
Is this under 100 chars?
gurleenkaurbp
approved these changes
Sep 24, 2024
|
SreejaMangarapu
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
https://folio-org.atlassian.net/browse/CIRC-2148
Approach
TODOS and Open Questions
Learning