Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MODFEE-311] Remove redundant fields from account schema #263

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

roman-barannyk
Copy link
Contributor

Purpose

  • Remove redundant fields from Account schema

Resolves: MODFEE-311

@id-jenkins
Copy link

INFO: api-schema-lint: Using api-schema-lint version: 1.0.5
INFO: api-schema-lint: Assessing schema files (https://dev.folio.org/guides/describe-schema/)
INFO: api-schema-lint: Found 84 JSON schema files under directory 'ramls'
ERROR: api-schema-lint: ramls/inventory/holdingsrecord.json: Missing "description" for: acquisitionFormat, acquisitionMethod, bareHoldingsItems, digitizationPolicy, electronicAccess, entries, holdingsInstance, holdingsItems, holdingsStatements, holdingsStatementsForIndexes, holdingsStatementsForSupplements, instanceId, permanentLocation, receivingHistory
ERROR: api-schema-lint: ramls/inventory/item.json: Missing "description" for: itemNoteType, permanentLocation, temporaryLocation
ERROR: api-schema-lint: ramls/inventory/location.json: Missing "description" for: campus, institution, library
ERROR: api-schema-lint: ramls/kv-configuration.json: Missing top-level "description".
ERROR: api-schema-lint: ramls/kv-configuration.json: Missing "description" for: code, configName, default, description, enabled, module, userId, value
ERROR: api-schema-lint: ramls/kv-configurations.json: Missing top-level "description".
ERROR: api-schema-lint: ramls/kv-configurations.json: Missing "description" for: configs
ERROR: api-schema-lint: ramls/loan-policy.json: Missing top-level "description".
ERROR: api-schema-lint: ramls/loan-policy.json: Missing "description" for: description, holds, loanable, loansPolicy, name, pages, recalls, renewalsPolicy, requestManagement
ERROR: api-schema-lint: There were processing errors. See list above.

Note: When those ERRORs are fixed, then any INFO and WARNING messages will be gone too. See Jenkins "Artifacts" tab for ApiSchemaLintReport.

@id-jenkins
Copy link

INFO: api-schema-lint: Using api-schema-lint version: 1.0.5
INFO: api-schema-lint: Assessing schema files (https://dev.folio.org/guides/describe-schema/)
INFO: api-schema-lint: Found 84 JSON schema files under directory 'ramls'
ERROR: api-schema-lint: ramls/inventory/holdingsrecord.json: Missing "description" for: acquisitionFormat, acquisitionMethod, bareHoldingsItems, digitizationPolicy, electronicAccess, entries, holdingsInstance, holdingsItems, holdingsStatements, holdingsStatementsForIndexes, holdingsStatementsForSupplements, instanceId, permanentLocation, receivingHistory
ERROR: api-schema-lint: ramls/inventory/item.json: Missing "description" for: itemNoteType, permanentLocation, temporaryLocation
ERROR: api-schema-lint: ramls/inventory/location.json: Missing "description" for: campus, institution, library
ERROR: api-schema-lint: ramls/kv-configuration.json: Missing top-level "description".
ERROR: api-schema-lint: ramls/kv-configuration.json: Missing "description" for: code, configName, default, description, enabled, module, userId, value
ERROR: api-schema-lint: ramls/kv-configurations.json: Missing top-level "description".
ERROR: api-schema-lint: ramls/kv-configurations.json: Missing "description" for: configs
ERROR: api-schema-lint: ramls/loan-policy.json: Missing top-level "description".
ERROR: api-schema-lint: ramls/loan-policy.json: Missing "description" for: description, holds, loanable, loansPolicy, name, pages, recalls, renewalsPolicy, requestManagement
ERROR: api-schema-lint: There were processing errors. See list above.

Note: When those ERRORs are fixed, then any INFO and WARNING messages will be gone too. See Jenkins "Artifacts" tab for ApiSchemaLintReport.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@id-jenkins
Copy link

INFO: api-schema-lint: Using api-schema-lint version: 1.0.5
INFO: api-schema-lint: Assessing schema files (https://dev.folio.org/guides/describe-schema/)
INFO: api-schema-lint: Found 84 JSON schema files under directory 'ramls'
ERROR: api-schema-lint: ramls/inventory/holdingsrecord.json: Missing "description" for: acquisitionFormat, acquisitionMethod, bareHoldingsItems, digitizationPolicy, electronicAccess, entries, holdingsInstance, holdingsItems, holdingsStatements, holdingsStatementsForIndexes, holdingsStatementsForSupplements, instanceId, permanentLocation, receivingHistory
ERROR: api-schema-lint: ramls/inventory/item.json: Missing "description" for: itemNoteType, permanentLocation, temporaryLocation
ERROR: api-schema-lint: ramls/inventory/location.json: Missing "description" for: campus, institution, library
ERROR: api-schema-lint: ramls/kv-configuration.json: Missing top-level "description".
ERROR: api-schema-lint: ramls/kv-configuration.json: Missing "description" for: code, configName, default, description, enabled, module, userId, value
ERROR: api-schema-lint: ramls/kv-configurations.json: Missing top-level "description".
ERROR: api-schema-lint: ramls/kv-configurations.json: Missing "description" for: configs
ERROR: api-schema-lint: ramls/loan-policy.json: Missing top-level "description".
ERROR: api-schema-lint: ramls/loan-policy.json: Missing "description" for: description, holds, loanable, loansPolicy, name, pages, recalls, renewalsPolicy, requestManagement
ERROR: api-schema-lint: There were processing errors. See list above.

Note: When those ERRORs are fixed, then any INFO and WARNING messages will be gone too. See Jenkins "Artifacts" tab for ApiSchemaLintReport.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants