Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MODFISTO-481] - Separate credits from expenditures in mod-finance-storage #414

Merged
merged 19 commits into from
Jun 19, 2024

Conversation

azizbekxm
Copy link
Contributor

@azizbekxm azizbekxm commented Jun 13, 2024

Purpose

https://folio-org.atlassian.net/browse/MODFISTO-481
https://folio-org.atlassian.net/browse/MODFIN-372

Approach

TODOS and Open Questions

Learning

Pre-Merge Checklist:

Before merging this PR, please go through the following list and take appropriate actions.

  • Does this PR meet or exceed the expected quality standards?
    • Code coverage on new code is 80% or greater
    • Duplications on new code is 3% or less
    • There are no major code smells or security issues
  • Does this introduce breaking changes?
    • Were any API paths or methods changed, added or removed?
    • Were there any schema changes?
    • Did any of the interface versions change?
    • Were permissions changed, added or removed?
    • Are there new interface dependencies?
    • There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

  • What other modules will these changes impact?
  • Do JIRAs exist to update the impacted modules?
    • If not, please create them
    • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
    • Do they have all the appropriate links to blocked/related issues?
  • Are the JIRAs under active development?
    • If not, contact the project's PO and make sure they're aware of the urgency.
  • Do PRs exist for these changes?
    • If so, have they been approved?
  • Did you modify code to call some additional endpoints?
    • If so, do you check that necessary module permission added in ModuleDescriptor-template.yaml file?

Ideally, all the PRs involved in breaking changes would be merged on the same day
to avoid breaking the folio-testing environment.
Communication is paramount if that is to be achieved,
especially as the number of inter-module and inter-team dependencies increase.

While it's helpful for reviewers to help identify potential problems,
ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

@azizbekxm azizbekxm requested a review from damien-git June 13, 2024 12:44
@azizbekxm azizbekxm marked this pull request as ready for review June 13, 2024 12:47
@azizbekxm azizbekxm requested a review from a team June 14, 2024 08:02
# Conflicts:
#	src/main/java/org/folio/utils/CalculationUtils.java
#	src/test/java/org/folio/utils/CalculationUtilsTest.java
Copy link

@azizbekxm azizbekxm merged commit 808aa04 into master Jun 19, 2024
8 checks passed
@azizbekxm azizbekxm deleted the MODFISTO-481 branch June 19, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants