Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MODFISTO-500] - Implement endpoint to return all finance data for FY #432

Merged
merged 7 commits into from
Nov 15, 2024
Merged

[MODFISTO-500] - Implement endpoint to return all finance data for FY #432

merged 7 commits into from
Nov 15, 2024

Conversation

azizbekxm
Copy link
Contributor

Purpose

https://folio-org.atlassian.net/browse/MODFISTO-500

Approach

  • implemented api to support search using fiscalYear
  • added tests

@azizbekxm azizbekxm changed the title [MODFISTO-500] - [MODFISTO-500] - Implement endpoint to return all finance data for FY Nov 15, 2024
@azizbekxm azizbekxm requested a review from a team November 15, 2024 07:08
SerhiiNosko
SerhiiNosko approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@SerhiiNosko SerhiiNosko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good approach

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@azizbekxm azizbekxm merged commit 6a2bebb into master Nov 15, 2024
12 checks passed
@azizbekxm azizbekxm deleted the MODFISTO-500 branch November 15, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SerhiiNosko SerhiiNosko SerhiiNosko approved these changes

@BKadirkhodjaev BKadirkhodjaev BKadirkhodjaev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@azizbekxm @SerhiiNosko @BKadirkhodjaev