MODFIN-283 - Migrated to vertx future #210

grabsefx · 2023-09-06T09:30:17Z

Purpose

https://issues.folio.org/browse/MODFIN-283

Approach

replaced CompletableFutue with vertx Future
new rest client

Learning

Code smells about replacing Collectors.toList() with newer toList() left untouched intentionally. Each case requires careful inspectation because toList() collector produces unmodifieble list, which potentially could cause UnsupportedOperationException in case of modification attempt.

Pre-Merge Checklist:

Before merging this PR, please go through the following list and take appropriate actions.

Does this PR meet or exceed the expected quality standards?
- Code coverage on new code is 80% or greater
- Duplications on new code is 3% or less
- There are no major code smells or security issues
Does this introduce breaking changes?
- Were any API paths or methods changed, added or removed?
- Were there any schema changes?
- Did any of the interface versions change?
- Were permissions changed, added or removed?
- Are there new interface dependencies?
- There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

What other modules will these changes impact?
Do JIRAs exist to update the impacted modules?
- If not, please create them
- Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
- Do they have all the appropriate links to blocked/related issues?
Are the JIRAs under active development?
- If not, contact the project's PO and make sure they're aware of the urgency.
Do PRs exist for these changes?
- If so, have they been approved?
Did you modify code to call some additional endpoints?
- If so, do you check that necessary module permission added in ModuleDescriptor-template.yaml file?

Ideally, all the PRs involved in breaking changes would be merged on the same day
to avoid breaking the folio-testing environment.
Communication is paramount if that is to be achieved,
especially as the number of inter-module and inter-team dependencies increase.

While it's helpful for reviewers to help identify potential problems,
ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.